Page MenuHome

Cleanup: Split curve bevel into separate file
ClosedPublic

Authored by Hans Goudey (HooglyBoogly) on Jul 29 2020, 8:26 PM.

Details

Summary

D8402 adds more functionality to curve bevels, and this section of code was getting long and messy already,
so now is a good time to separate it from curve.c (which is already quite long).

This patch also:

  1. Adds fill_type enum, just local to curve_bevel.c. This makes testing which sections of the curve to build much more intuitive.
  2. Uses use_bevel and use_extrude shorthand variables.
  3. Splits each case into a separate function, so the main BKE_curve_bevel_make function is more readable.

Diff Detail

Repository
rB Blender

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Jul 29 2020, 8:26 PM

Minor changes:

  • Use curve_bevel_make_ prefix for bevel calculation functions to distinguish them from other utility functions.
  • Rename curve_bevel_general_case to curve_bevel_make_extrude_and_fill.
This revision was not accepted when it landed; it landed in state Needs Review.Jul 30 2020, 6:59 AM
This revision was automatically updated to reflect the committed changes.