Page MenuHome
Differential D8431

Fix T79117: dependency cycle with passive rigid body objects
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Jul 30 2020, 2:57 PM.

Details

Reviewers
Sergey Sharybin (sergey)
Sebastian Parborg (zeddb)
Maniphest Tasks
T79117: Rigid body costraint produces dependency cycle
Commits
rB8dc2fbd7b666: Fix T79117: dependency cycle with passive rigid body objects
Summary

I only have a very limited understanding of how rigid bodies are
integrated into the depsgraph. However, it seems to make sense that
passive objects don't have to depend on the simulation and don't
need to sync back the transforms. Those objects are ignored in
BKE_rigidbody_sync_transforms anyway.

Alls tests pass after this change, but not sure if we are testing
simulations yet.

Diff Detail

Repository
rB Blender

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Jul 30 2020, 2:57 PM
Jacques Lucke (JacquesLucke) created this revision.
Harbormaster completed remote builds in B9264: Diff 27293.Jul 30 2020, 2:57 PM
Jacques Lucke (JacquesLucke) added a task: T79117: Rigid body costraint produces dependency cycle.Jul 30 2020, 2:58 PM
RedMser (RedMser) added a subscriber: RedMser (RedMser).Jul 30 2020, 5:37 PM
Sebastian Parborg (zeddb) accepted this revision.Jul 30 2020, 6:16 PM
Sebastian Parborg (zeddb) added a subscriber: Sebastian Parborg (zeddb).

I feel that the logic is sound and the code looks good to me at least.

I'm doing kinda the same things in https://developer.blender.org/D5797

I do like your split if style more than the big if statement I did in mine.

So perhaps we can apply this first and I'll modify the other patch so it applies on top of this?

This revision is now accepted and ready to land.Jul 30 2020, 6:16 PM
Closed by commit rB8dc2fbd7b666: Fix T79117: dependency cycle with passive rigid body objects (authored by Jacques Lucke (JacquesLucke)). · Explain WhyJul 30 2020, 6:26 PM
This revision was automatically updated to reflect the committed changes.
Jacques Lucke (JacquesLucke) added a commit: rB8dc2fbd7b666: Fix T79117: dependency cycle with passive rigid body objects.
Sebastian Parborg (zeddb) mentioned this in D8732: Fix Depsgraph passive and constraint transform relations..Aug 27 2020, 4:08 PM

Revision Contents
Changeset List

PathSize
source/
blender/
depsgraph/
intern/
builder/
6 lines
25 lines

Diff 27311

View Options

source/blender/depsgraph/intern/builder/deg_builder_nodes.cc

Loading...
View Options

source/blender/depsgraph/intern/builder/deg_builder_relations.cc

Loading...