Page MenuHome

Buildbot: build automatically when git commits are made
ClosedPublic

Authored by Brecht Van Lommel (brecht) on Jul 31 2020, 12:51 PM.

Details

Summary

But don't package and upload them, that only happens nightly still.
There will be one build per set of commits that arrives within 120s
of each other.

The idea behind this is that it will help us more easily find which
commits break the build or tests.

Diff Detail

Event Timeline

Brecht Van Lommel (brecht) requested review of this revision.Jul 31 2020, 12:51 PM
Brecht Van Lommel (brecht) created this revision.

Is it presented as a separate builder in the interface?

How are the seconds measured? If one works for a month in a separate branch and merges/cherry-picks 100s of commits which are more than 120s apart, how much this will clog the builder?

Windows builder would need more work from the worker_compile.py side. The reason for that is because it is not possible to tap into cpack step happening in worker_pack.py so instead codesign is doen as part of the install target. This target is also used by the regression tests (basically Blender is installed twice). The codesign of install used for tests is to be ignored for the poller builder as well.

Is it presented as a separate builder in the interface?

It's not. We already have quite a few builders. I think a single builder per branch with some of the builds being code signed and uploaded can work fine.

How are the seconds measured? If one works for a month in a separate branch and merges/cherry-picks 100s of commits which are more than 120s apart, how much this will clog the builder?

I believe it will group all those 100s of commits together and do 1 build. As far as I can tell from looking at the buildbot implementation, it does not look at the git commit dates but rather the time when buildbot pulled those commits.

Seems fine.
Guess we need to deploy changes to both buildbot and blender at the same time.

Also, not sure if anything will need to be done in 2.83 branch (to avoid unrecognized command line argument perhaps?)

This revision is now accepted and ready to land.Aug 3 2020, 2:45 PM

Don't do package step if we are not going to upload.

This can take a couple of minutes even without code signing, so avoid that overhead.

The --codesign parameter commit would indeed need to be backported to 2.83 as well.