I think it makes more sense to just remove the text_is_edited check completely. The results are the same for me anyway, for buttons with and without labels.

In D8441#206073, @Hans Goudey (HooglyBoogly) wrote:

Thanks for the patch!

I think it makes more sense to just remove the text_is_edited check completely. The results are the same for me anyway, for buttons with and without labels.

I had the same thought at first, but it turns out that without the check, multi-editing center-aligned widgets adds an unwanted offset:

In D8441#206106, @RedMser (RedMser) wrote:

I had the same thought at first, but it turns out that without the check, multi-editing center-aligned widgets adds an unwanted offset:

Aha! I figured you had some reason, just wanted to make sure. In that case I think this is good to go. It would be good for you or whoever commits this to add a comment explaining this.

This revision is now accepted and ready to land.Aug 3 2020, 8:33 PM

Add comment

Harbormaster completed remote builds in B9332: Diff 27390.Aug 4 2020, 11:47 AM

Good catch, thanks!
I did a slight correction to keep the code semantically correct. text_is_edited should only be true if the text is actually being edited. Extra conditions should be checked separately by the if-statement.
Logically this was perfectly fine though.

Closed by commit rBb313710c10f9: Fix padding when multi-editing aligned widgets (authored by Red Mser <RedMser>, committed by Julian Eisel (Severin)). · Explain WhyAug 6 2020, 1:35 PM

This revision was automatically updated to reflect the committed changes.

Julian Eisel (Severin) added a commit: rBb313710c10f9: Fix padding when multi-editing aligned widgets.