Page MenuHome
Differential D8477

GPencil: Invert Filled area pressing Ctrl key
ClosedPublic
Actions

Authored by Antonio Vazquez (antoniov) on Aug 5 2020, 7:10 PM.

Details

Reviewers
Matias Mendiola (mendio)
Daniel Martinez Lara (pepeland)
Commits
rB4ada2909566c: GPencil: Invert Filled area pressing Ctrl key
Summary

This feature was suggested in https://blender.community/c/rightclickselect/rggbbc/

When press Ctrl+LMB, the filled area is inverted.

Filling several areas:

Diff Detail

Repository
rB Blender
Branch
temp-gpencil-fill-invert (branched from master)
Build Status
Buildable 9367
Build 9367: arc lint + arc unit

Event Timeline

Antonio Vazquez (antoniov) requested review of this revision.Aug 5 2020, 7:10 PM
Antonio Vazquez (antoniov) created this revision.
Harbormaster completed remote builds in B9367: Diff 27451.Aug 5 2020, 7:10 PM
Antonio Vazquez (antoniov) edited the summary of this revision. (Show Details)Aug 5 2020, 7:12 PM
Antonio Vazquez (antoniov) added reviewers: Matias Mendiola (mendio), Daniel Martinez Lara (pepeland).
Antonio Vazquez (antoniov) added a project: Grease Pencil.
Antonio Vazquez (antoniov) added a subscriber: Pablo Vazquez (pablovazquez).
Antonio Vazquez (antoniov) updated this revision to Diff 27453.Aug 5 2020, 8:02 PM
  • GPencil: Replace Fill Send to Back Keymap to Invert Fill
Harbormaster completed remote builds in B9368: Diff 27453.Aug 5 2020, 8:02 PM
Tomasz Kaye (bitbutter) awarded a token.Aug 5 2020, 8:52 PM
Matias Mendiola (mendio) added a comment.Aug 6 2020, 2:14 PM

For shortcuts consistency we should use CTRL key like in Sculpt brushes to invert the tool functionality and also expose the +/- on the top header

Antonio Vazquez (antoniov) updated this revision to Diff 27489.EditedAug 6 2020, 5:41 PM
  • GPencil: Add new Invert option to Fill brushes. Now it's possible define a direction by default.

  • GPencil: Change Fill keymaps
  • Ctrl invert fill area.
  • Shift Draw lines. (before it was Ctrl)

Use Ctrl for invert is more logic because it follows invert Brush mode used in Blender in other areas.

Harbormaster completed remote builds in B9386: Diff 27489.Aug 6 2020, 5:41 PM
Antonio Vazquez (antoniov) retitled this revision from GPencil: Invert Filled area pressing Shift key to GPencil: Invert Filled area pressing Ctrl key.Aug 6 2020, 5:42 PM
Antonio Vazquez (antoniov) edited the summary of this revision. (Show Details)
Antonio Vazquez (antoniov) updated this revision to Diff 27495.Aug 6 2020, 7:22 PM
  • GPencil: Remove unused keymap in Fill mode
  • GPencil: Disable Stabilizer when drawing inside Fill
Harbormaster completed remote builds in B9390: Diff 27495.Aug 6 2020, 7:22 PM
Antonio Vazquez (antoniov) edited the summary of this revision. (Show Details)Aug 6 2020, 7:50 PM
Antonio Vazquez (antoniov) edited the summary of this revision. (Show Details)
Antonio Vazquez (antoniov) updated this revision to Diff 27541.Aug 8 2020, 5:27 PM
Fill Several areas at the same time
Harbormaster completed remote builds in B9421: Diff 27541.Aug 8 2020, 5:27 PM
Antonio Vazquez (antoniov) edited the summary of this revision. (Show Details)Aug 8 2020, 5:28 PM
Antonio Vazquez (antoniov) updated this revision to Diff 27542.Aug 8 2020, 7:32 PM
  • GPencil: Fix dilate of the fill shape
Harbormaster completed remote builds in B9422: Diff 27542.Aug 8 2020, 7:32 PM
Matias Mendiola (mendio) accepted this revision.Aug 10 2020, 4:31 PM
This revision is now accepted and ready to land.Aug 10 2020, 4:31 PM
Closed by commit rB4ada2909566c: GPencil: Invert Filled area pressing Ctrl key (authored by Antonio Vazquez (antoniov)). · Explain WhyAug 10 2020, 4:35 PM
This revision was automatically updated to reflect the committed changes.
Antonio Vazquez (antoniov) added a commit: rB4ada2909566c: GPencil: Invert Filled area pressing Ctrl key.
Pratik Borhade (PratikPB2123) mentioned this in T101507: Ctrl-LMB to Fill Gap (Grease Pencil).Oct 1 2022, 5:56 AM

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
gpencil/
39 lines

Diff 27451

View Options

source/blender/editors/gpencil/gpencil_fill.c

Loading...