Sculpt: Cloth Brush simulation area property
ClosedPublic
Actions

Authored by Pablo Dobarro (pablodp606) on Aug 6 2020, 2:13 AM.

Details

Reviewers

Sergey Sharybin (sergey)

Commits

rBd693d77fed96: Sculpt: Cloth Brush simulation area property

Summary

This makes possible to choose between a local and a global simulation
when the cloth brush is used. Local simulation is the current default.
When global simulation is enabled, the cloth brush simulates the entire
mesh without taking any simulation limits into account.

This was possible before by setting the simulation limits to 10 (the
current maximum value allowed) so the entire mesh was inside the limits,
but this was a hack as the limits scale with the radius and there should
not be any limitation on how big the simulated area can be to be able to
simulate an entire object. This also allows to make a more clear
distinction between cloth brush presets that are intended to be used in
local areas to add details or globally to generate the base shape of the
mesh.

Diff Detail

Repository: rB Blender

Event Timeline

Pablo Dobarro (pablodp606) created this revision.Aug 6 2020, 2:13 AM

Harbormaster completed remote builds in B9373: Diff 27465.Aug 6 2020, 2:13 AM

Pablo Dobarro (pablodp606) requested review of this revision.Aug 6 2020, 2:13 AM

Pablo Dobarro (pablodp606) edited the summary of this revision. (Show Details)Aug 6 2020, 2:15 AM

Pablo Dobarro (pablodp606) added a reviewer: Sergey Sharybin (sergey).

Kenn Nyström (Frozen_Death_Knight) awarded a token.Aug 6 2020, 5:14 AM

Lopo Isaac (lopoIsaac) awarded a token.Aug 6 2020, 6:49 AM

This change seems fine.
But please make sure the feedback on technical debt gets addressed.

source/blender/editors/sculpt_paint/paint_cursor.c
1569–1570	There are two things here (which are not directly related to this specific patch, but which needs to be addressed as a followup change nevertheless): This entire function is the handbook example of what is considered too long and what is to be split into smaller ones. The comment which comes prior to `else` outside of the branch it describes is confusing and often misleading. Move explanation of what happens in the specific branch to the branch itself.