Page MenuHome

Fix unwrap not working with only one pinned vertex.
ClosedPublic

Authored by Willis (wlssirius) on Aug 6 2020, 4:15 PM.

Details

Summary

This commit fixes T79590 UV Island Won't Unwrap If Only One Vertex Is Pinned

When unwrapping UV island with only one pinned vertex, it will unwrap as if there's no pin, and then translate the whole island to keep pinned vertex position unchanged.

  1. Pin only one vertex

  1. Select all and unwrap

Diff Detail

Branch
fix-unwrap-with-one-pin (branched from master)
Build Status
Buildable 9409
Build 9409: arc lint + arc unit

Event Timeline

Willis (wlssirius) requested review of this revision.Aug 6 2020, 4:15 PM

Updating D8484: fix unwrap not working with only one pinned vertex. This commit fixes

T79590

Willis (wlssirius) retitled this revision from fix unwrap not working with only one pinned vertex. This commit fixes T79590 to Fix unwrap not working with only one pinned vertex..Aug 6 2020, 4:31 PM
Willis (wlssirius) edited the summary of this revision. (Show Details)
Brecht Van Lommel (brecht) requested changes to this revision.Aug 6 2020, 4:53 PM

Thanks for the patch. I think the solution should be a bit different The automatically found pins are not necessarily good candidates for pinning along with any other vertex.

Instead I think it can still pick 2 pins automatically, but then after unwrapping translate the entire UV chart so that the pinned UV remains in place.

This revision now requires changes to proceed.Aug 6 2020, 4:53 PM
  • resolve comment
Willis (wlssirius) edited the summary of this revision. (Show Details)Aug 7 2020, 7:29 PM

Thanks, I made a bunch more changes to ensure rotation and scale is also correct and that it works with live unwrap.

This revision is now accepted and ready to land.Aug 12 2020, 12:07 PM