Page MenuHome
Differential D8486

GPencil: Patch old files after the change in how the first frame is used
ClosedPublic
Actions

Authored by Antonio Vazquez (antoniov) on Aug 6 2020, 4:33 PM.

Details

Reviewers
Dalai Felinto (dfelinto)
Maniphest Tasks
T79567: Grease Pencil fill regression
Commits
rB96e460ed9b30: GPencil: Patch old files after the change in how the first frame is used
Summary

This patching duplicates the first frame of the layer if the first frame number is not equals to the scene first frame number.

Related to T79567

This is the result after applying the patch (Left 2.83, right 2.90)

Diff Detail

Repository
rB Blender

Event Timeline

Antonio Vazquez (antoniov) requested review of this revision.Aug 6 2020, 4:33 PM
Antonio Vazquez (antoniov) created this revision.
Antonio Vazquez (antoniov) added a task: T79567: Grease Pencil fill regression.
Antonio Vazquez (antoniov) edited the summary of this revision. (Show Details)Aug 6 2020, 4:48 PM
Antonio Vazquez (antoniov) edited the summary of this revision. (Show Details)
Dalai Felinto (dfelinto) accepted this revision.Aug 6 2020, 5:22 PM
Dalai Felinto (dfelinto) added inline comments.
source/blender/blenloader/intern/versioning_290.c
199

Nit picking, I would either move both ifs to the same line, or do a short exit for the first one. In other words:

A) if (gpf && gpf->framenum > scene->r.sfra) {

B)

if (gpf != NULL) {
    continue;
}
This revision is now accepted and ready to land.Aug 6 2020, 5:22 PM
Closed by commit rB96e460ed9b30: GPencil: Patch old files after the change in how the first frame is used (authored by Antonio Vazquez (antoniov)). · Explain WhyAug 6 2020, 5:29 PM
This revision was automatically updated to reflect the committed changes.
Antonio Vazquez (antoniov) added a commit: rB96e460ed9b30: GPencil: Patch old files after the change in how the first frame is used.

Revision Contents
Changeset List

PathSize
source/
blender/
blenloader/
intern/
19 lines

Diff 27487

View Options

source/blender/blenloader/intern/versioning_290.c

Loading...