Page MenuHome
Differential D848

manual - rst drivers
AbandonedPublic
Actions

Authored by koil (koilz) on Oct 28 2014, 1:58 PM.

Details

Reviewers
Francesco Siddi (fsiddi)
Summary

Ive not done this much before so, I dunno.

This a patch to update some of the drivers page in the manual.
https://www.blender.org/manual/animation/basics/drivers.html

Diff Detail

Event Timeline

koil (koilz) updated this revision to Diff 2764.Oct 28 2014, 1:58 PM
koil (koilz) retitled this revision from to manual - rst drivers.
koil (koilz) updated this object.
koil (koilz) set the repository for this revision to Unknown Object (Repository).
koil (koilz) added a project: Documentation.
koil (koilz) added a comment.Oct 28 2014, 2:12 PM

Added picture.

Francesco Siddi (fsiddi) requested changes to this revision.Oct 28 2014, 6:06 PM
Francesco Siddi (fsiddi) added a reviewer: Francesco Siddi (fsiddi).
Francesco Siddi (fsiddi) added a subscriber: Francesco Siddi (fsiddi).

Hey there @koil (koilz), great to see you here :)
All in all your proposal is good, I've just highlighted some changes regarding the titling style and other details.

If you could update the patch I'll include it in the docs right away!

manual/animation/basics/drivers.rst
154

Since this comes after a title of type

heading 2
=========

it should be

heading 3
---------

with dashes instead of ^ signs.

162–163

Not sure why you are going for *italic* here. In general we don't use this for these elements, since they become already bold in the generate html. If you could remove it would be great.

164

See similar above.

170–176

See similar above.

185

See similar above.

192

See similar above.

This revision now requires changes to proceed.Oct 28 2014, 6:06 PM
koil (koilz) updated this revision to Diff 2772.Oct 28 2014, 6:44 PM
koil (koilz) edited edge metadata.
koil (koilz) set the repository for this revision to Unknown Object (Repository).

Added changes.

Francesco Siddi (fsiddi) requested changes to this revision.Oct 28 2014, 6:47 PM
Francesco Siddi (fsiddi) edited edge metadata.

A couple of notes, sorry for not being clear enough, it's my bad. After that everything is fine.

manual/animation/basics/drivers.rst
13

I'm really sorry if i was not clear. There is no need to put any * here. The text will become bold automatically.

17

Same here.

This revision now requires changes to proceed.Oct 28 2014, 6:47 PM
koil (koilz) added a comment.Oct 28 2014, 6:55 PM

k.
Ill make a patch.

I wasnt sure if I needed to set the repository each time I upload a new patch.
The field was blank when I added a revision.

koil (koilz) updated this revision to Diff 2773.Oct 28 2014, 7:00 PM
koil (koilz) edited edge metadata.
koil (koilz) set the repository for this revision to Unknown Object (Repository).

Added changes.

Francesco Siddi (fsiddi) accepted this revision.Oct 28 2014, 10:17 PM
Francesco Siddi (fsiddi) edited edge metadata.

Great, I'll merge it asap! Thank you very much for your patience :)

This revision is now accepted and ready to land.Oct 28 2014, 10:17 PM
koil (koilz) abandoned this revision.Oct 31 2014, 1:53 PM

Seems the changes have been committed.
Closing.

Revision Contents
Changeset List

PathSize
manual/
animation/
basics/
drivers.rst
drivers.rst
78 lines

Diff 2773

View Options

manual/animation/basics/drivers.rst

Loading...