Fix T79622: Mesh Filter on a locked Shapekey crashes
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Aug 7 2020, 6:30 PM.

Details

Reviewers

Pablo Dobarro (pablodp606)
Bastien Montagne (mont29)

Maniphest Tasks

T79622: Active Shape Key Lock cause Blender crash while using Mesh Filter, Move, Rotate, Scale, Transform tools.

Commits

rB21118fb610c2: Fix T79622: Mesh Filter on a locked Shape crashes

Summary

For a locked shapekey, a SculptSession's orig_cos / deform_cos /
deform_imats are not initialized (and probably dont need to be, since we
can just update that keyblock with sculpt_update_keyblock() it seems)

Diff Detail

Repository

rB Blender

Branch

T79622 (branched from master)

Build Status

Buildable 9479
Build 9479: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Aug 7 2020, 6:30 PM

Philipp Oeser (lichtwerk) created this revision.

Harbormaster completed remote builds in B9406: Diff 27524.Aug 7 2020, 6:30 PM

Philipp Oeser (lichtwerk) added a project: Sculpt, Paint & Texture.Aug 7 2020, 6:30 PM

Philipp Oeser (lichtwerk) retitled this revision from Fix T79622: Mesh Filter on a locked Shape crashes to Fix T79622: Mesh Filter on a locked Shapekey crashes.

Pablo Dobarro (pablodp606) accepted this revision.Aug 10 2020, 7:29 PM

This revision is now accepted and ready to land.Aug 10 2020, 7:29 PM

Since we are a bit on shaky ground here, I would appreciate a third pair of eyes, maybe you can have a look @Bastien Montagne (mont29)?

Won't pretend I fully understand this code, but from what I can see it looks valid...

Am not sure though if you should not rather check on ss->deform_modifiers_active? Wouldn't this be a more generic/logically correct check? Afaict orig_cos are only generated when this flag is true?

This revision now requires changes to proceed.Aug 12 2020, 11:48 AM