Generally fine, but here is a tricky part which can't be solved as this code review: there feels to be code duplication which can and should be easily addressed. For example, the logic which happens in mesh_filter_intensify_details_init_directions() is needed by both filter and the brush.

This revision now requires changes to proceed.Aug 10 2020, 12:00 PM

Oops, meant to accept, as the de-duplication can't happen as the part of this patchset.

This revision is now accepted and ready to land.Aug 10 2020, 12:01 PM

Hi, nice feature... but instead of calling it "Intensify", why not call it "Amplify"? At least that's what this feature is usually called in most 3d softwares...
Cheers...

TheRedWaxPolice (TheRedWaxPolice) awarded a token.Aug 10 2020, 10:01 PM

In image/signal processing it is called "sharpen".
"Amplify" is more ambiguous here because it does not explicitly means "increase amplitude of high-frequency details".

We already have a sharpen operation, which is the one that creases the edges and smooths the surface at the same time D7335.
Is it fine to commit this and discuss the UI naming in a later design task?

Closed by commit rB0957189d4a3a: Sculpt: Enhance Details Mesh Filter (authored by Pablo Dobarro (pablodp606)). · Explain WhyAug 18 2020, 4:57 PM

This revision was automatically updated to reflect the committed changes.

Pablo Dobarro (pablodp606) added a commit: rB0957189d4a3a: Sculpt: Enhance Details Mesh Filter.