Timers: Set first window as context in timer.
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Aug 11 2020, 10:52 AM.

Details

Reviewers

Brecht Van Lommel (brecht)
Campbell Barton (campbellbarton)

Commits

rB6d888133da1c: Timers: set first window as context in timer

Summary

This is part of T79690.

The same approach is used in various other places in Blender already.
Searching for the regex CTX_wm_window_set.*first reveals some cases.

This already fixes a few crashes we get when running python code in timers.

Diff Detail

Repository

rB Blender

Branch

timers-window-context (branched from master)

Build Status

Buildable 9455
Build 9455: arc lint + arc unit

Event Timeline

Jacques Lucke (JacquesLucke) created this revision.Aug 11 2020, 10:52 AM

Harbormaster completed remote builds in B9455: Diff 27598.Aug 11 2020, 10:52 AM

Jacques Lucke (JacquesLucke) requested review of this revision.Aug 11 2020, 10:52 AM

Jacques Lucke (JacquesLucke) added reviewers: Brecht Van Lommel (brecht), Campbell Barton (campbellbarton).Aug 11 2020, 10:52 AM

Brecht Van Lommel (brecht) accepted this revision.Aug 11 2020, 11:16 AM

This revision is now accepted and ready to land.Aug 11 2020, 11:16 AM

Closed by commit rB6d888133da1c: Timers: set first window as context in timer (authored by Jacques Lucke (JacquesLucke)). · Explain WhyAug 11 2020, 1:25 PM

This revision was automatically updated to reflect the committed changes.

Jacques Lucke (JacquesLucke) added a commit: rB6d888133da1c: Timers: set first window as context in timer.

Jacques Lucke (JacquesLucke) mentioned this in T62074: 2.8: Python API: crash due to missing window context in Application timer.Sep 16 2020, 9:52 AM

Revision Contents
Changeset List

Path

Size

source/

blender/

windowmanager/

intern/

wm_event_system.c

14 lines

Diff 27598

View Options

source/blender/windowmanager/intern/wm_event_system.c

Timers: Set first window as context in timer.ClosedPublicActions