UI: Add auto keyframing popover
ClosedPublic
Actions

Authored by Hans Goudey (HooglyBoogly) on Aug 11 2020, 2:52 PM.

Details

Reviewers

Julian Eisel (Severin)
Sybren A. Stüvel (sybren)
Campbell Barton (campbellbarton)
Pablo Vazquez (pablovazquez)
Sebastian Parborg (zeddb)
Luciano Muñoz Sessarego (looch)

Group Reviewers

User Interface
Animation & Rigging

Commits

rB099ce95ef36d: UI: Add auto keyframing popover

Summary

For other areas in Blender that have a toggle and related settings we put a popover with the settings right next to the toggle.

This combination is nice because it organizes the settings without making interaction slower.
It also makes the settings more discoverable since they're right next to the toggle.

Before	After

Diff Detail

Repository: rB Blender

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Aug 11 2020, 2:52 PM

Hans Goudey (HooglyBoogly) created this revision.

Harbormaster completed remote builds in B9461: Diff 27611.Aug 11 2020, 2:52 PM

Hans Goudey (HooglyBoogly) retitled this revision from For other areas in Blender that have a toggle and related settings we put a popover with the settings right next to the toggle. to UI: Add auto keyframing popover.Aug 11 2020, 2:54 PM

Hans Goudey (HooglyBoogly) edited the summary of this revision. (Show Details)

Deactivate the popover button when auto keframing is off

Harbormaster completed remote builds in B9462: Diff 27612.Aug 11 2020, 2:57 PM

Hans Goudey (HooglyBoogly) edited the summary of this revision. (Show Details)

Hans Goudey (HooglyBoogly) added reviewers: User Interface, Animation & Rigging.

Hans Goudey (HooglyBoogly) added projects: User Interface, Animation & Rigging.

jorge (jorsh) awarded a token.Aug 11 2020, 4:52 PM

Hans Goudey (HooglyBoogly) edited the summary of this revision. (Show Details)Aug 11 2020, 6:26 PM

Campbell Barton (campbellbarton) accepted this revision as: Campbell Barton (campbellbarton).Aug 12 2020, 9:32 AM

This revision is now accepted and ready to land.Aug 12 2020, 9:32 AM

RedMser (RedMser) added a subscriber: RedMser (RedMser).Aug 12 2020, 12:41 PM

Andy Cuccaro (AndyCuccaro) awarded a token.Aug 13 2020, 2:05 PM

I wouldnt deactivate the popover button when autokey is off because you might want to change the settings before enabling autokey.

In D8537#209046, @Luciano Muñoz Sessarego (looch) wrote:

I wouldnt deactivate the popover button when autokey is off because you might want to change the settings before enabling autokey.

You can still edit the settings if the button is inactive, it just means it's grayed out. We do the same for the 3D view's popovers.

Oh yeah I do find it a bit confusing , but consistent. but confusing.

Gilberto Rodrigues (gilberto_rodrigues) awarded a token.Aug 18 2020, 10:47 PM

Pablo Vazquez (pablovazquez) accepted this revision.Sep 2 2020, 5:20 PM

Sebastian Parborg (zeddb) added a subscriber: Sebastian Parborg (zeddb).Sep 16 2020, 4:20 PM

Sebastian Parborg (zeddb) added inline comments.