Page MenuHome

Cycles : add a Volume Geometry Node
ClosedPublic

Authored by Kévin Dietrich (kevindietrich) on Aug 11 2020, 3:19 PM.

Details

Summary

This splits the volume related data (properties for rendering and attributes) of the Mesh node
into a new Volume node type.

This Volume node derives from the Mesh class since we generate a mesh for the bounds of the
volume, as such we can safely work on Volumes as if they were Meshes, e.g. for BVH creation.
However such code should still check for the geometry type of the object to be MESH or VOLUME
which may be bug prone if this is forgotten.

This is part of T79131.

Diff Detail

Repository
rB Blender

Event Timeline

Kévin Dietrich (kevindietrich) requested review of this revision.Aug 11 2020, 3:19 PM
Kévin Dietrich (kevindietrich) created this revision.

This looks good for master.

I guess the next step would be to move the code from mesh_volume.cpp into volume.cpp? No need to have separate files for that.

This revision is now accepted and ready to land.Aug 12 2020, 12:52 PM