Multires: Base Mesh Sculpting
ClosedPublic
Actions

Authored by Pablo Dobarro (pablodp606) on Aug 12 2020, 8:20 PM.

Details

Reviewers

Sergey Sharybin (sergey)
Julian Eisel (Severin)

Commits

rB976f0113e008: Multires: Base Mesh Sculpting

Summary

This adds an option to the Multires modifier to sculpt directly on the
base mesh while previewing the displacement of a higher subdivisions
level. What this does it considering Multires as a regular modifier
without exposing the grid displacement to sculpt mode.

This allows to see the propagation happening in real time, which enables
to use complex tools like Cloth or Pose in much higher resolutions and
without surface noise and artifacts.

Cloth Brush running in real time deforming 260k vertices of displacement:

Diff Detail

Repository

rB Blender

Branch

sculpt-multires-base-mesh (branched from master)

Build Status

Buildable 9493
Build 9493: arc lint + arc unit

Event Timeline

Pablo Dobarro (pablodp606) requested review of this revision.Aug 12 2020, 8:20 PM

Pablo Dobarro (pablodp606) created this revision.

Harbormaster completed remote builds in B9493: Diff 27687.Aug 12 2020, 8:21 PM

Pablo Dobarro (pablodp606) edited the summary of this revision. (Show Details)Aug 12 2020, 8:22 PM

Pablo Dobarro (pablodp606) added a reviewer: Sergey Sharybin (sergey).

AnityEx (AnityEx) awarded a token.Aug 12 2020, 8:29 PM

Rodger Davis (RodDavis) awarded a token.Aug 12 2020, 8:36 PM

kouza (kouza) awarded a token.Aug 13 2020, 12:34 PM

Kenn Nyström (Frozen_Death_Knight) awarded a token.Aug 13 2020, 1:08 PM

Diogo Valadares Reis dos Santos (DiogoX2) awarded a token.Aug 13 2020, 4:19 PM

Julien Kaspar (JulienKaspar) awarded a token.Aug 13 2020, 4:25 PM

Some commentary from me to ensure evaluation and sculpting is always in sync in terms of logic around whether multires is used or not.

The interface I am not sure. Talked to @Julien Kaspar (JulienKaspar) , and it makes sense to have option in the modifier, but feels weird to have sculpting-related option always exposed in all modes. @Julian Eisel (Severin) for the rescue! ;)

source/blender/blenkernel/intern/DerivedMesh.c
913–914	Sounds like this should be using `BKE_sculpt_multires_active()`. In rare configurations you can have 2 multires modifiers, and have one of them "Sculpt on Base" enabled, but disabled on another. Using `BKE_sculpt_multires_active` will ensure the evaluation and sculpting code is perfectly in sync.

This revision now requires changes to proceed.Aug 13 2020, 4:41 PM

Showing such an option like this is not too nice. But I think it's acceptable if we disable it outside of sculpt mode. Just make sure there's a "disabled hint" (the red text in the tooltip explaining why it's disabled).

Two decent options for that:

UI_block_lock_set()/UI_block_lock_clear() around the item in panel_draw()
Add an _editable() callback to the RNA property. These have the r_info parameter for this disabled hint.