Page MenuHome

Sculpt: Option to limit the forces axis in the Cloth Filter
ClosedPublic

Authored by Pablo Dobarro (pablodp606) on Aug 14 2020, 12:43 AM.
Tags
None
Tokens
"Love" token, awarded by gilberto_rodrigues."Like" token, awarded by Frozen_Death_Knight."Love" token, awarded by julperado.

Details

Summary

This uses the same concept of the Mesh Filter but for applying the cloth
filter forces, so now it can be limited to a specific axis.

Diff Detail

Repository
rB Blender
Branch
arcpatch-D8567 (branched from master)
Build Status
Buildable 9527
Build 9527: arc lint + arc unit

Event Timeline

Pablo Dobarro (pablodp606) requested review of this revision.Aug 14 2020, 12:43 AM
Pablo Dobarro (pablodp606) created this revision.

For those types of expanded enums I think it makes sense to use a subrow. That way when the layout is vertical all three X Y Z buttons stay on the same row.

@Hans Goudey (HooglyBoogly) I tempt to agree having axis in a single line is more readable, but not sure its something you can easily do? @Julian Eisel (Severin)?

source/blender/editors/sculpt_paint/sculpt_intern.h
924–926

Not sure why forces is plural, is a single force from what i understand.

Confusing part here is: what is the difference between enabled_axis and enabled_forces_axis ? Is it needed to have two separate "sets" of enabled axis? Which "set" is active in which mode?

Tested, it's just a matter of adding a aligned row for the change in space_toolsystem_toolbar.py. +1

  • Rename Forces to Force
  • Use a row for the XYZ UI
Pablo Dobarro (pablodp606) marked an inline comment as done.Aug 14 2020, 6:58 PM
Pablo Dobarro (pablodp606) added inline comments.
source/blender/editors/sculpt_paint/sculpt_intern.h
924–926

enabled_axis is used for displacement, which is currently used in the mesh filter and I would also like to support in the cloth filter as a separate thing. That would mean that you will be able to compress a piece of cloth like it was constrained by collisions, but without using collisions. I'll do this in a separate patch because it will need some tweaks in the solver.

Sergey Sharybin (sergey) added inline comments.
source/blender/editors/sculpt_paint/sculpt_intern.h
924–926

Ok, but then suggestion to do after this change before going deeper is to:

  • Rename enabled_axis to enabled_displacement_axis.
  • Maybe add more elaborate comments, stating cloth and other usages.
This revision is now accepted and ready to land.Aug 17 2020, 9:33 AM
release/scripts/startup/bl_ui/space_toolsystem_toolbar.py
1288–1289