Page MenuHome

Fix Cloth Brush Grab deform types not working with spacing
ClosedPublic

Authored by Pablo Dobarro (pablodp606) on Aug 14 2020, 1:49 AM.

Details

Summary

Even the Cloth Brush grab works like a regular grab brush, it makes
sense to support spacing just in this brush in order to prevent creating
more brush steps that update the simulation. This way, it is possible to
create grab brushes that update the simulation constantly while grabbing
(using the dots stroke mode) or brushes that only update the simulation
when the cursor moves (using spacing).

Diff Detail

Repository
rB Blender

Event Timeline

Pablo Dobarro (pablodp606) requested review of this revision.Aug 14 2020, 1:49 AM

Nice result, but please fix the comment.

source/blender/editors/sculpt_paint/paint_stroke.c
1000–1012

I would do it as if ((br->flag & BRUSH_SPACE) == 0) {. Is kind of way more difficult to miss == 0 than ! when having a quick read.

1005
1006
Pablo Dobarro (pablodp606) marked 3 inline comments as done.
  • Review update

Review update

Am I missing something or spelling in the comment is still not corrected?

This revision is now accepted and ready to land.Aug 18 2020, 9:10 AM