Differential D8573

Fix T77340: nested nodes alpha issues
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Aug 14 2020, 2:47 PM.

Tags

None

Subscribers

None

Details

Reviewers

Campbell Barton (campbellbarton)
Julian Eisel (Severin)

Maniphest Tasks

T77340: Nested frame nodes alpha issue

Commits

rBb2d9020aa5d9: Fix T77340: nested nodes alpha issues

Summary

I'm not sure why these different cases existed in the first place. They were introduced in rB53b01d90023a850b17ded5deb9cace354c8e298a a long time ago.
It's not quite clear to me why nodes should have different shadows when they are in a frame or not.

Old:

Old with zero alpha:

New:

New with zero alpha:

Diff Detail

Repository

Branch

node-shadows (branched from master)

Build Status

Buildable 9522
Build 9522: arc lint + arc unit

Event Timeline

Jacques Lucke (JacquesLucke) created this revision.Aug 14 2020, 2:47 PM

Harbormaster completed remote builds in B9522: Diff 27736.Aug 14 2020, 2:47 PM

Jacques Lucke (JacquesLucke) requested review of this revision.Aug 14 2020, 2:47 PM

Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)Aug 14 2020, 2:51 PM

Jacques Lucke (JacquesLucke) added reviewers: Campbell Barton (campbellbarton), Julian Eisel (Severin).

Jacques Lucke (JacquesLucke) added a task: T77340: Nested frame nodes alpha issue.

Looks reasonable. I don't see a point in the old behavior either.

This revision is now accepted and ready to land.Aug 17 2020, 10:47 AM

Closed by commit rBb2d9020aa5d9: Fix T77340: nested nodes alpha issues (authored by Jacques Lucke (JacquesLucke)). · Explain WhyAug 17 2020, 12:35 PM

This revision was automatically updated to reflect the committed changes.

Jacques Lucke (JacquesLucke) added a commit: rBb2d9020aa5d9: Fix T77340: nested nodes alpha issues.

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

space_node/

17 lines

Diff 27736

source/blender/editors/space_node/node_draw.c

Loading...