Page MenuHome
Differential D8576

UI: Only draw node menu search if categories exist
ClosedPublic
Actions

Authored by Omar Emara (OmarSquircleArt) on Aug 14 2020, 9:11 PM.

Details

Reviewers
Jacques Lucke (JacquesLucke)
Commits
rBe14de692fc99: UI: Only draw node menu search if categories exist
Summary

Currently, the search operator in the node add menu NODE_MT_add is drawn
even if no node categories exists. This patch only draws the operator if
at least one node category passes the poll.

This patch is needed because some add-ons use custom search operator and
do not register node categories. In this case, it is undesirable to have
a search operator drawn that do nothing and is not used. One such add-on
is Animation Nodes.

Diff Detail

Repository
rB Blender

Event Timeline

Omar Emara (OmarSquircleArt) created this revision.Aug 14 2020, 9:11 PM
Harbormaster completed remote builds in B9529: Diff 27745.Aug 14 2020, 9:11 PM
Omar Emara (OmarSquircleArt) requested review of this revision.Aug 14 2020, 9:11 PM
Joao Morgado (MrJomo) awarded a token.Aug 14 2020, 9:37 PM
Joao Morgado (MrJomo) added a subscriber: Joao Morgado (MrJomo).
Jacques Lucke (JacquesLucke) accepted this revision.Aug 17 2020, 10:38 AM
Jacques Lucke (JacquesLucke) added inline comments.
release/scripts/startup/bl_ui/space_node.py
217

Incorrect whitespace.

This revision is now accepted and ready to land.Aug 17 2020, 10:38 AM
Closed by commit rBe14de692fc99: UI: Only draw node menu search if categories exist (authored by Omar Emara (OmarSquircleArt)). · Explain WhyAug 17 2020, 1:42 PM
This revision was automatically updated to reflect the committed changes.
Omar Emara (OmarSquircleArt) added a commit: rBe14de692fc99: UI: Only draw node menu search if categories exist.

Revision Contents
Changeset List

PathSize
release/
scripts/
modules/
8 lines
startup/
bl_ui/
12 lines

Diff 27785

View Options

release/scripts/modules/nodeitems_utils.py

Loading...
View Options

release/scripts/startup/bl_ui/space_node.py

Loading...