Details

Reviewers

Sergey Sharybin (sergey)
Julian Eisel (Severin)

Commits

rBcfeadaa29594: Fix Mesh Filter deformation axis UI layout

Summary

This uses a single row for the three axis instead of a row per axis.

Diff Detail

Repository: rB Blender

Event Timeline

Pablo Dobarro (pablodp606) requested review of this revision.Aug 15 2020, 5:07 PM

Pablo Dobarro (pablodp606) created this revision.

Harbormaster completed remote builds in B9538: Diff 27755.Aug 15 2020, 5:07 PM

Pablo Dobarro (pablodp606) added a reviewer: Sergey Sharybin (sergey).Aug 15 2020, 7:20 PM

Fine by me.
@Julian Eisel (Severin), do you want to have a second pass here?

This revision is now accepted and ready to land.Aug 17 2020, 9:54 AM

I'd prefer to explicitly set align=True though. I don't know why it's aligning right now, could even be a bug.
Either way, better to just set it to make your intend clear and unambiguous, and to avoid breakage when the default changes for whatever reason.

Julian Eisel (Severin) mentioned this in D8567: Sculpt: Option to limit the forces axis in the Cloth Filter.Aug 17 2020, 10:43 AM

Closed by commit rBcfeadaa29594: Fix Mesh Filter deformation axis UI layout (authored by Pablo Dobarro (pablodp606)). · Explain WhyAug 18 2020, 12:33 PM

This revision was automatically updated to reflect the committed changes.

Pablo Dobarro (pablodp606) added a commit: rBcfeadaa29594: Fix Mesh Filter deformation axis UI layout.