Paths

Table of Contentst

Differential D8583

Fix Mask Slice deleting the Face Sets
ClosedPublic
Actions

Authored by Pablo Dobarro (pablodp606) on Aug 15 2020, 7:50 PM.

Tags

None

Subscribers

Przemyslaw Golab (SirPigeonz) (n-pigeon)

Tokens

"Love" token, awarded by n-pigeon."Like" token, awarded by Frozen_Death_Knight.

Details

Reviewers

Sergey Sharybin (sergey)

Commits

rBca7414c4cb4c: Fix Mask Slice deleting the Face Sets

Summary

This was a TODO in the code. Previously the Face Set datalayer was
deleted and recreated with a constant ID of 0. Now the datalayer is
preserved and set to the SculptSession after slicing the mask and a new
ID is calculated for the new faces that the slicing operation produced,
so they can be easily isolated for further tweaking.

Diff Detail

Repository

Branch

fix-mask-slice-face-sets (branched from master)

Build Status

Buildable 9572
Build 9572: arc lint + arc unit

Event Timeline

Pablo Dobarro (pablodp606) requested review of this revision.Aug 15 2020, 7:50 PM

Pablo Dobarro (pablodp606) created this revision.

Harbormaster completed remote builds in B9541: Diff 27758.Aug 15 2020, 7:50 PM

Pablo Dobarro (pablodp606) edited the summary of this revision. (Show Details)Aug 15 2020, 7:50 PM

Pablo Dobarro (pablodp606) added a reviewer: Sergey Sharybin (sergey).

Kenn Nyström (Frozen_Death_Knight) awarded a token.Aug 15 2020, 10:19 PM

Generally fine, but I suggest making more re-usable utility functions.
Think there are more places where you need to find unique Face ID,

source/blender/editors/mesh/editmesh_mask_extract.c
432–436	This sounds like could become own utility function.
438–443	Same as above.

Przemyslaw Golab (SirPigeonz) (n-pigeon) awarded a token.Aug 17 2020, 11:20 AM

Przemyslaw Golab (SirPigeonz) (n-pigeon) added a subscriber: Przemyslaw Golab (SirPigeonz) (n-pigeon).

Review update: use utility functions

Harbormaster completed remote builds in B9572: Diff 27799.Aug 17 2020, 6:20 PM

Sergey Sharybin (sergey) accepted this revision.Aug 18 2020, 9:08 AM

Sergey Sharybin (sergey) added inline comments.

source/blender/editors/include/ED_sculpt.h
58	Suggestion: `ED_sculpt_face_sets_initialize_none_to_id`

This revision is now accepted and ready to land.Aug 18 2020, 9:08 AM

Closed by commit rBca7414c4cb4c: Fix Mask Slice deleting the Face Sets (authored by Pablo Dobarro (pablodp606)). · Explain WhyAug 18 2020, 12:20 PM

This revision was automatically updated to reflect the committed changes.

Pablo Dobarro (pablodp606) added a commit: rBca7414c4cb4c: Fix Mask Slice deleting the Face Sets.

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

include/

4 lines

mesh/

editmesh_mask_extract.c

16 lines

sculpt_paint/

sculpt_face_set.c

31 lines

Diff 27799

source/blender/editors/include/ED_sculpt.h

Loading...

source/blender/editors/mesh/editmesh_mask_extract.c

Loading...

source/blender/editors/sculpt_paint/sculpt_face_set.c

Loading...