Cycles: move some Scene related methods out of Session
ClosedPublic
Actions

Authored by Kévin Dietrich (kevindietrich) on Aug 17 2020, 10:53 AM.

Details

Reviewers

Brecht Van Lommel (brecht)
Sergey Sharybin (sergey)

Commits

rCf382b05c719d: Move some scene related methods out of session
rBc82166ffcd88: Cycles: move some Scene related methods out of Session

Summary

This moves Session::get_requested_device_features,
Session::load_kernels, and Session::update_scene out of Session
and into Scene, as mentioned in D8544.

Diff Detail

Repository

rB Blender

Branch

cycles_session_refactor (branched from master)

Build Status

Buildable 9554
Build 9554: arc lint + arc unit

Event Timeline

Kévin Dietrich (kevindietrich) created this revision.Aug 17 2020, 10:53 AM

Harbormaster completed remote builds in B9554: Diff 27776.Aug 17 2020, 10:53 AM

Kévin Dietrich (kevindietrich) requested review of this revision.Aug 17 2020, 10:53 AM

Kévin Dietrich (kevindietrich) added inline comments.Aug 17 2020, 10:54 AM

intern/cycles/render/scene.cpp
406	@Sergey Sharybin (sergey), I guess this comment is referring to what I did in this patch, so it can be removed?

Brecht Van Lommel (brecht) added inline comments.Aug 17 2020, 11:04 AM

intern/cycles/render/scene.cpp
406	That sounds right.
408	`requested_features.experimental` doesn't do anything in the device anymore, so can be removed entirely.
448	Replace by `if (film->denoising_data_pass) {`
466–486	This camera and AA samples update can remain in the session. At some later point this can go through the API and get automatic update tagging.
521	This can be a return value of the function somehow, so that session reset remains in the session.
intern/cycles/render/scene.h
282–305	Session and SessionParams should not be passed to the scene, the dependency should be one way.