Page MenuHome
Differential D8592

Fix T79757: Crash on prefetch when renaming strips
ClosedPublic
Actions

Authored by Richard Antalik (ISS) on Aug 17 2020, 1:10 PM.

Details

Reviewers
Sergey Sharybin (sergey)
Maniphest Tasks
T79757: Renaming Video Strip then scrubbing crashes (prefetching frames)
Commits
rB4b69e55da358: Fix T79757: Crash on prefetch when renaming strips
Summary

Original sequence lookup failed, becase name changed in another thread.
Fix is same as 0471349c90df - stop prefetching before changing content
of seqbase.

I have covered more cases, and added assert so it is more obvious that
issue is in lookup, and it shouldn't fail.

Diff Detail

Repository
rB Blender
Branch
T79757 (branched from master)
Build Status
Buildable 9560
Build 9560: arc lint + arc unit

Event Timeline

Richard Antalik (ISS) created this revision.Aug 17 2020, 1:10 PM
Harbormaster completed remote builds in B9560: Diff 27784.Aug 17 2020, 1:10 PM
Richard Antalik (ISS) requested review of this revision.Aug 17 2020, 1:10 PM
Sergey Sharybin (sergey) accepted this revision.Aug 17 2020, 2:03 PM
This revision is now accepted and ready to land.Aug 17 2020, 2:03 PM
Closed by commit rB4b69e55da358: Fix T79757: Crash on prefetch when renaming strips (authored by Richard Antalik (ISS)). · Explain WhyAug 17 2020, 8:37 PM
This revision was automatically updated to reflect the committed changes.
Richard Antalik (ISS) added a commit: rB4b69e55da358: Fix T79757: Crash on prefetch when renaming strips.

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
intern/
1 line
editors/
space_sequencer/
6 lines
makesrna/
intern/
2 lines

Diff 27784

View Options

source/blender/blenkernel/intern/seqcache.c

Loading...
View Options

source/blender/editors/space_sequencer/sequencer_edit.c

Loading...
View Options

source/blender/makesrna/intern/rna_sequencer.c

Loading...