Differential D8593

Fix T77683: Cycles baking crash with motion blur enabled and no camera specified
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Aug 17 2020, 2:21 PM.

Tags

None

Subscribers

None

Details

Reviewers

Brecht Van Lommel (brecht)

Maniphest Tasks

T77683: Crash when trying to bake texture

Commits

rC142dfcdfb748: Fix T77683: Cycles baking crash with motion blur enabled and no camera specified
rB1012569dfa34: Fix T77683: Cycles baking crash with motion blur enabled and no camera
rBe157573fab2a: Fix T77683: Cycles baking crash with motion blur enabled and no camera

Diff Detail

Repository: rB Blender

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Aug 17 2020, 2:21 PM

Harbormaster completed remote builds in B9561: Diff 27786.Aug 17 2020, 2:21 PM

Philipp Oeser (lichtwerk) requested review of this revision.Aug 17 2020, 2:21 PM

Brecht Van Lommel (brecht) added inline comments.Aug 17 2020, 2:43 PM

intern/cycles/blender/blender_object.cpp
437–439	Skipping the entire function seems wrong to me, we just exclude just the ones involving the camera.
461–463	This one line.
468–474	These 3 lines.

dont skip the entire function (review by @Brecht Van Lommel (brecht))

Harbormaster completed remote builds in B9569: Diff 27794.Aug 17 2020, 5:13 PM

Brecht Van Lommel (brecht) accepted this revision.Aug 17 2020, 6:27 PM

This revision is now accepted and ready to land.Aug 17 2020, 6:27 PM

Closed by commit rBe157573fab2a: Fix T77683: Cycles baking crash with motion blur enabled and no camera (authored by Philipp Oeser (lichtwerk)). · Explain WhyAug 17 2020, 9:10 PM

This revision was automatically updated to reflect the committed changes.

Philipp Oeser (lichtwerk) added a commit: rBe157573fab2a: Fix T77683: Cycles baking crash with motion blur enabled and no camera.

Jeroen Bakker (jbakker) added a commit: rB1012569dfa34: Fix T77683: Cycles baking crash with motion blur enabled and no camera.Aug 26 2020, 12:03 PM

Brecht Van Lommel (brecht) added a commit: rC142dfcdfb748: Fix T77683: Cycles baking crash with motion blur enabled and no camera specified.Sep 1 2020, 1:58 AM

Revision Contents
Changeset List

Path

Size

intern/

cycles/

blender/

blender_object.cpp

12 lines

Diff 27813

intern/cycles/blender/blender_object.cpp

Loading...