Build deps: Enable SSE optimization for FFmpeg
ClosedPublic
Actions

Authored by Sergey Sharybin (sergey) on Aug 17 2020, 2:26 PM.

Details

Reviewers

Brecht Van Lommel (brecht)
Ray Molenkamp (LazyDodo)
Bastien Montagne (mont29)

Maniphest Tasks

T79848: Re-compile FFmpeg libraries with SSE support

Commits

rB400ab197023f: Build deps: Enable SSE optimization for FFmpeg

Summary

The description is self-explanatory: enable SSE optimizations in the
FFmpeg library. They were disabled from the very beginning of the
dependency builder, possibly due to portability concerns.

FFmpeg does perform runtime check for available CPU microarchitectures,
so the codecs will still run on older hardware, but they will run way
faster on newer hardware.

For example, re-encoding 3405 2560x1376 frames on Xeon E5-2699 V4 CPU
went down from 313sec to 210.

After applying this patch the precompiled libraries are to be updated.

Diff Detail

Repository: rB Blender

Event Timeline

Sergey Sharybin (sergey) requested review of this revision.Aug 17 2020, 2:26 PM

Sergey Sharybin (sergey) created this revision.

Harbormaster completed remote builds in B9562: Diff 27787.Aug 17 2020, 2:26 PM

Sergey Sharybin (sergey) added a subscriber: Francesco Siddi (fsiddi).Aug 17 2020, 2:28 PM

Brecht Van Lommel (brecht) accepted this revision.Aug 17 2020, 2:35 PM

This revision is now accepted and ready to land.Aug 17 2020, 2:35 PM

It would be good to create a task on the 2.91 workboard for this, to keep track of which platforms still need to be updated.

@Brecht Van Lommel (brecht), true. But there is no 2.91 workboard yet :\

Sergey Sharybin (sergey) mentioned this in T79848: Re-compile FFmpeg libraries with SSE support.Aug 17 2020, 2:44 PM

Sergey Sharybin (sergey) added a task: T79848: Re-compile FFmpeg libraries with SSE support.

Note that install_deps already did not use those options to disable sse when compiling ffmpeg, so this part of our libs handling can be considered OK already?

@Bastien Montagne (mont29) thanks for checking. Indeed looks like install_deps is all covered and good!

lgtm, will update svn libs after this lands.

Closed by commit rB400ab197023f: Build deps: Enable SSE optimization for FFmpeg (authored by Sergey Sharybin (sergey)). · Explain WhyAug 18 2020, 11:17 AM

This revision was automatically updated to reflect the committed changes.

Sergey Sharybin (sergey) added a commit: rB400ab197023f: Build deps: Enable SSE optimization for FFmpeg.

Ray Molenkamp (LazyDodo) mentioned this in rBL62481: Windows: ffmpeg 4.2.3 with D8594 .Aug 31 2020, 5:50 PM