Paths

Table of Contentst

Differential D8598

Fix C operators can't set default display or sort type for File Browser
ClosedPublic
Actions

Authored by Julian Eisel (Severin) on Aug 17 2020, 7:22 PM.

Tags

Subscribers

Pablo Vazquez (pablovazquez)

Tokens

"Love" token, awarded by pablovazquez.

Details

Reviewers

Bastien Montagne (mont29)

Commits

rBc067b7460a1f: Fix C operators can't set default display or sort type for File Browser

Summary

WM_operator_properties_filesel() allows C operators to set a display or sort
type for the File Browser to use. But the File Browser would always override
that because of an invalid _is_set() check. (The operators don't actually set
the value, they only set the property's default value.)

The only operator affected by this is "Recover Auto Save". It is supposed to
show a vertical list ordered chronologically. It used settings from the
previous File Browser usage before this patch.

Further change:
This also makes it so operators that set a different display or sort type
don't change the sort or display type for the next File Browser operation.
So using "Recover Auto Save" entirely isolates display and sort type from other
operations.

Diff Detail

Repository

Branch

temp-fileselect-defaults (branched from master)

Build Status

Buildable 10259
Build 10259: arc lint + arc unit

Event Timeline

Julian Eisel (Severin) requested review of this revision.Aug 17 2020, 7:22 PM

Julian Eisel (Severin) created this revision.

Harbormaster completed remote builds in B9576: Diff 27804.Aug 17 2020, 7:22 PM

Julian Eisel (Severin) edited the summary of this revision. (Show Details)Aug 17 2020, 7:24 PM

Julian Eisel (Severin) added a project: User Interface.

Julian Eisel (Severin) edited the summary of this revision. (Show Details)

Generally looks fine, besides note below.

source/blender/windowmanager/intern/wm_operator_props.c
107–127	Not very happy to have this duplicated in two completely different places... This is call for divergence at some point or another. Potential solutions: Use a define for the four common entries. Or keep the exported enum with four entries, and add a callback to the operator properties to add the `DEFAULT` option?

This revision now requires changes to proceed.Aug 27 2020, 8:00 PM

Pablo Vazquez (pablovazquez) awarded a token.Sep 8 2020, 6:04 PM

Deduplicate sort type enum definition

The same treatment should be given to file_display_items(), but will do that
separately.

Harbormaster completed remote builds in B10259: Diff 28970.Sep 17 2020, 2:54 PM

Correction to previous update

Harbormaster completed remote builds in B10260: Diff 28971.Sep 17 2020, 2:57 PM

Bastien Montagne (mont29) accepted this revision.Oct 6 2020, 11:35 AM

This revision is now accepted and ready to land.Oct 6 2020, 11:35 AM

Closed by commit rBc067b7460a1f: Fix C operators can't set default display or sort type for File Browser (authored by Julian Eisel (Severin)). · Explain WhyNov 3 2020, 12:01 AM

This revision was automatically updated to reflect the committed changes.

Julian Eisel (Severin) added a commit: rBc067b7460a1f: Fix C operators can't set default display or sort type for File Browser.

Julian Eisel (Severin) mentioned this in rBa750acab78cf: Fix possible use-after-free when closing Blender with File Browser open.

Aras Pranckevicius (aras_p) mentioned this in D15906: Fix T100887: Some C++ importers/exporters (e.g. OBJ) reset file dialog Sort By mode.Sep 7 2022, 9:02 PM

Aras Pranckevicius (aras_p) mentioned this in rB129993c026e9: Fix T100887: Some C++ importers/exporters (e.g. OBJ) reset file dialog Sort By….Sep 8 2022, 12:08 PM

Philipp Oeser (lichtwerk) mentioned this in rBfaccd880385b: Fix T100887: Some C++ importers/exporters (e.g. OBJ) reset file dialog Sort By….Sep 21 2022, 2:28 PM

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

curve/

4 lines

io/

2 lines

object/

object_modifier.c

2 lines

object_volume.c

2 lines

physics/

rigidbody_world.c

2 lines

screen/

2 lines

sound/

6 lines

space_buttons/

4 lines

space_clip/

2 lines

space_file/

21 lines

5 lines

43 lines

space_graph/

2 lines

space_image/

6 lines

space_info/

2 lines

space_node/

2 lines

space_sequencer/

sequencer_add.c

6 lines

sequencer_edit.c

4 lines

space_text/

4 lines

space_view3d/

2 lines

makesdna/

DNA_space_types.h

12 lines

makesrna/

RNA_enum_types.h

3 lines

intern/

42 lines

windowmanager/

intern/

6 lines

wm_files_link.c

8 lines

wm_operator_props.c

53 lines

Diff 28970

source/blender/editors/curve/editfont.c

Loading...

source/blender/editors/io/io_cache.c

Loading...

source/blender/editors/object/object_modifier.c

Loading...

source/blender/editors/object/object_volume.c

Loading...

source/blender/editors/physics/rigidbody_world.c

Loading...

source/blender/editors/screen/screendump.c

Loading...

source/blender/editors/sound/sound_ops.c

Loading...

source/blender/editors/space_buttons/buttons_ops.c

Loading...

source/blender/editors/space_clip/clip_ops.c

Loading...

source/blender/editors/space_file/file_ops.c

Loading...

source/blender/editors/space_file/filelist.c

Loading...

source/blender/editors/space_file/filesel.c

Loading...

source/blender/editors/space_graph/graph_edit.c

Loading...

source/blender/editors/space_image/image_ops.c

Loading...

source/blender/editors/space_info/info_ops.c

Loading...

source/blender/editors/space_node/node_add.c

Loading...

source/blender/editors/space_sequencer/sequencer_add.c

Loading...

source/blender/editors/space_sequencer/sequencer_edit.c

Loading...

source/blender/editors/space_text/text_ops.c

Loading...

source/blender/editors/space_view3d/view3d_edit.c

Loading...

source/blender/makesdna/DNA_space_types.h

Loading...

source/blender/makesrna/RNA_enum_types.h

Loading...

source/blender/makesrna/intern/rna_space.c

Loading...

source/blender/windowmanager/intern/wm_files.c

Loading...

source/blender/windowmanager/intern/wm_files_link.c

Loading...

source/blender/windowmanager/intern/wm_operator_props.c

Loading...