Differential D859

Fixing clamp flag of Math shader node and MixRGB shader node in Blender Render
AbandonedPublic
Actions

Authored by Alexander Romanov (a.romanov) on Oct 30 2014, 8:41 AM.

Details

Reviewers

Lukas Tönne (lukastoenne)
Brecht Van Lommel (brecht)
Jeroen Bakker (jbakker)
Ton Roosendaal (ton)

Maniphest Tasks

T42445: Clamp flag has no effect on result value in Math and MixRGB shader nodes (Blender Render)

Summary

Clamp flag had no effect on result value.
This diff fixes the problem.

Best regards,
Blend4Web Team.

Diff Detail

Repository: rB Blender

Event Timeline

Alexander Romanov (a.romanov) updated this revision to Diff 2788.Oct 30 2014, 8:41 AM

Alexander Romanov (a.romanov) retitled this revision from to Fixing clamp flag of Math shader node and MixRGB shader node in Blender Render.

Alexander Romanov (a.romanov) updated this object.

Alexander Romanov (a.romanov) updated this object.Oct 30 2014, 8:45 AM

Alexander Romanov (a.romanov) added subscribers: Dontsov Valentin (valentin_b4w), Evgeny_Rodygin.

Alexander Romanov (a.romanov) added a task: T42445: Clamp flag has no effect on result value in Math and MixRGB shader nodes (Blender Render).Oct 30 2014, 10:34 AM

Alexander Romanov (a.romanov) added reviewers: Ton Roosendaal (ton), Lukas Tönne (lukastoenne), Brecht Van Lommel (brecht), Jeroen Bakker (jbakker).Oct 30 2014, 10:40 AM

That looks all good to me,
@Lukas Tönne (lukastoenne) maybe you could look over it again and commit it - it's not that complex and decreases the bug o meter ;)

Thanks for the patch, but i've noticed ti too late and just committed slightly more clear fix..

source/blender/gpu/shaders/gpu_shader_material.glsl
312	Wouldn't call it that specific, imo makes sense to have more generic purpose names,
source/blender/nodes/shader/nodes/node_shader_math.c
281	You can use something like: GPU_link(mat, "math_clamp", out[0].link, &out[0].link); instead.
source/blender/nodes/shader/nodes/node_shader_mixRgb.c
64	This is wrong, custom2 also has bitflag for alpha.

Yuri Kovelenov (yurikovelenov) added a subscriber: Yuri Kovelenov (yurikovelenov).Nov 5 2014, 2:25 PM

Thomas Beck (plasmasolutions) removed a subscriber: Thomas Beck (plasmasolutions).Nov 5 2014, 2:39 PM

Thanks for your remarks anyway!

If this is obsolete now, please close it (abandon it). Thanks.

In D859#13892, @Thomas Dinges (dingto) wrote:

If this is obsolete now, please close it (abandon it). Thanks.

Revision Contents
Changeset List

Path

Size

source/

blender/

gpu/

shaders/

gpu_shader_material.glsl

10 lines

nodes/

shader/

nodes/

node_shader_math.c

9 lines

node_shader_mixRgb.c

18 lines

Diff 2788

source/blender/gpu/shaders/gpu_shader_material.glsl

Loading...

source/blender/nodes/shader/nodes/node_shader_math.c

Loading...

source/blender/nodes/shader/nodes/node_shader_mixRgb.c

Loading...