UI: Remove panel X axis closing code
ClosedPublic
Actions

Authored by Hans Goudey (HooglyBoogly) on Aug 17 2020, 8:19 PM.

Details

Reviewers

Julian Eisel (Severin)

Commits

rBeb9055a572c3: UI: Remove panel X axis closing code

Summary

Horizontal panel alignment hasn't been used for years, and we have no
plans to use it in the future. It adds a fair amount of complexity to
the panel code which makes adding features take longer.

This code removes the X closing flag, and all of the logic / variables
unused without it.

Diff Detail

Repository: rB Blender

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Aug 17 2020, 8:19 PM

Hans Goudey (HooglyBoogly) created this revision.

Harbormaster completed remote builds in B9579: Diff 27808.Aug 17 2020, 8:19 PM

Incement proper versioning define
Use the same value as PNL_CLOSEDY for better backward compatibility

Harbormaster completed remote builds in B9585: Diff 27818.Aug 17 2020, 10:44 PM

Hans Goudey (HooglyBoogly) mentioned this in D8291: Cleanup: interface_panel.c: Renaming, comment formatting, some cleanup.Aug 17 2020, 11:29 PM

Merge branch 'master' into remove-panel-x-closing

Harbormaster completed remote builds in B9643: Diff 27913.Aug 19 2020, 4:40 PM

I only checked the versioning code quickly, but that seems fine besides a code style suggestion.

Please try if opening 2.4 files works with this, especially with tabbed panels and horizontal layouts. Although, IIRC you can't open 2.49 files currently anyway - if that's still the case, don't bother and just commit this.

source/blender/blenloader/intern/versioning_290.c
240–246	I prefer to keep using defines. There could be one `PNL_UNUSED_1` flag, and for the re-used bit you can just use `PNL_CLOSED` here too (maybe mentioning in a comment here that the bit used to mean something different). We do the same in other places, e.g. `IMA_HIGH_BITDEPTH`.