Differential D8607

GPencil: Split vertex size for grease pencil
ClosedPublic
Actions

Authored by Antonio Vazquez (antoniov) on Aug 18 2020, 1:40 PM.

Details

Reviewers

Clément Foucault (fclem)

Maniphest Tasks

T79800: Gpencil. Grease Pencil Vertex Size in theme settings is ignored

Commits

rB017941057f8a: Fix T79800: Split vertex size for grease pencil

Summary

Related to T79800

It's better keep size of grease pencil vertex in a different parameter and not reuse mesh vertex size.

Diff Detail

Repository

rB Blender

Branch

temp-vertex_size (branched from master)

Build Status

Buildable 9595
Build 9595: arc lint + arc unit

Event Timeline

Antonio Vazquez (antoniov) requested review of this revision.Aug 18 2020, 1:40 PM

Antonio Vazquez (antoniov) created this revision.

Harbormaster completed remote builds in B9595: Diff 27842.Aug 18 2020, 1:40 PM

Antonio Vazquez (antoniov) added a task: T79800: Gpencil. Grease Pencil Vertex Size in theme settings is ignored.Aug 18 2020, 1:41 PM

Antonio Vazquez (antoniov) edited the summary of this revision. (Show Details)

Antonio Vazquez (antoniov) added a reviewer: Clément Foucault (fclem).

Antonio Vazquez (antoniov) mentioned this in T79800: Gpencil. Grease Pencil Vertex Size in theme settings is ignored.

Clément Foucault (fclem) accepted this revision.Aug 18 2020, 1:42 PM

This revision is now accepted and ready to land.Aug 18 2020, 1:42 PM

Closed by commit rB017941057f8a: Fix T79800: Split vertex size for grease pencil (authored by Antonio Vazquez (antoniov)). · Explain WhyAug 18 2020, 3:14 PM

This revision was automatically updated to reflect the committed changes.

Antonio Vazquez (antoniov) added a commit: rB017941057f8a: Fix T79800: Split vertex size for grease pencil.

Revision Contents
Changeset List

Path

Size

source/

blender/

draw/

engines/

overlay/

shaders/

edit_gpencil_vert.glsl

2 lines

intern/

draw_common.h

3 lines

draw_common.c

1 line

shaders/

common_globals_lib.glsl

3 lines

Diff 27842

View Options

source/blender/draw/engines/overlay/shaders/edit_gpencil_vert.glsl

View Options

source/blender/draw/intern/draw_common.h

View Options

source/blender/draw/intern/draw_common.c

View Options

source/blender/draw/intern/shaders/common_globals_lib.glsl

GPencil: Split vertex size for grease pencilClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 27842

source/blender/draw/engines/overlay/shaders/edit_gpencil_vert.glsl

source/blender/draw/intern/draw_common.h

source/blender/draw/intern/draw_common.c

source/blender/draw/intern/shaders/common_globals_lib.glsl

GPencil: Split vertex size for grease pencil
ClosedPublic
Actions

Revision Contents
Changeset List