Cleanup: remove unused `RemoteAddressRecorder` middleware
ClosedPublic
Actions

Authored by Sybren A. Stüvel (sybren) on Aug 18 2020, 2:23 PM.

Details

Reviewers

Francesco Siddi (fsiddi)

Commits

rBDF2e43a38234e9: Cleanup: remove unused `RemoteAddressRecorder` middleware

Summary

I don't think the RemoteAddressRecorder middleware is used anywhere. It doesn't seem to be used in templates or Python code. From what I can see, the only code that uses the user's remote address is the preferred currency middleware, but that doesn't use RemoteAddressRecorder.

It did get me confused when I tried to figure out why some exception occurred, so IMO it should be removed.

Diff Detail

Repository: rBDF Blender Dev Fund

Event Timeline

Sybren A. Stüvel (sybren) requested review of this revision.Aug 18 2020, 2:23 PM

Sybren A. Stüvel (sybren) created this revision.

Sybren A. Stüvel (sybren) edited the summary of this revision. (Show Details)

Maybe it's a leftover from an earlier implementation of the currency detector?
The code does not look familiar to me and also can't think of functionality that makes use of this.
Ok for removal.

This revision is now accepted and ready to land.Aug 18 2020, 10:50 PM

Closed by commit rBDF2e43a38234e9: Cleanup: remove unused `RemoteAddressRecorder` middleware (authored by Sybren A. Stüvel (sybren)). · Explain WhySep 3 2020, 5:25 PM

This revision was automatically updated to reflect the committed changes.

Sybren A. Stüvel (sybren) added a commit: rBDF2e43a38234e9: Cleanup: remove unused `RemoteAddressRecorder` middleware.