Page MenuHome
Differential D8615

Silence `-Wmaybe-uninitialized` warning on GCC/Linux
ClosedPublic
Actions

Authored by Sybren A. Stüvel (sybren) on Aug 18 2020, 5:51 PM.

Details

Reviewers
Sergey Sharybin (sergey)
Bastien Montagne (mont29)
Commits
rB948e080fc5bb: Silence `-Wmaybe-uninitialized` warning on GCC/Linux
Summary

Add -Wno-maybe-uninitialized option to CMAKE_CXX_FLAGS_RELEASE and CMAKE_CXX_FLAGS_RELWITHDEBINFO variables on GCC/Linux.

In Release builds GCC's -Wmaybe-uninitialized warning is unreliable, and thus causes noise that can drown out other warnings. These warnings are now silenced in release mode builds.a

Debug builds seem fine, so flags for debug builds are not touched by this commit.

No functional changes.

Diff Detail

Repository
rB Blender
Branch
arcpatch-D8615 (branched from master)
Build Status
Buildable 9684
Build 9684: arc lint + arc unit

Event Timeline

Sybren A. Stüvel (sybren) requested review of this revision.Aug 18 2020, 5:51 PM
Sybren A. Stüvel (sybren) created this revision.
Harbormaster completed remote builds in B9616: Diff 27880.Aug 18 2020, 5:51 PM
Sergey Sharybin (sergey) requested changes to this revision.Aug 19 2020, 9:34 AM

Instead of copying flags to RELEASE/RELWITHDEBINFO C/CXX can create a single list of all the flags we want to add, and add them to all the CMAKE variables as needed.

build_files/cmake/platform/platform_unix.cmake
594–595

Keep C and C++ flags matched unless otherwise is not possible.

This revision now requires changes to proceed.Aug 19 2020, 9:34 AM
Jacques Lucke (JacquesLucke) added a subscriber: Jacques Lucke (JacquesLucke).Aug 19 2020, 10:39 AM
Sybren A. Stüvel (sybren) updated this revision to Diff 27959.Aug 20 2020, 10:22 AM
  • Feedback Sergey
Harbormaster completed remote builds in B9678: Diff 27959.Aug 20 2020, 10:22 AM
Bastien Montagne (mont29) accepted this revision.Aug 20 2020, 12:03 PM

LGTM

Sergey Sharybin (sergey) added inline comments.Aug 20 2020, 12:29 PM
build_files/cmake/platform/platform_unix.cmake
595–596

Unless i'm missing something, should be C and C++.
Unless C does not support -Wno-maybe-uninitialized for whatever reason.

Sybren A. Stüvel (sybren) updated this revision to Diff 27969.Aug 20 2020, 1:50 PM
  • Moar update, now actually the correct one.
Harbormaster completed remote builds in B9684: Diff 27969.Aug 20 2020, 1:50 PM
Sybren A. Stüvel (sybren) marked an inline comment as done.Aug 20 2020, 1:50 PM
Sergey Sharybin (sergey) accepted this revision.Aug 20 2020, 4:05 PM
This revision is now accepted and ready to land.Aug 20 2020, 4:05 PM
Closed by commit rB948e080fc5bb: Silence `-Wmaybe-uninitialized` warning on GCC/Linux (authored by Sybren A. Stüvel (sybren)). · Explain WhyAug 20 2020, 4:18 PM
This revision was automatically updated to reflect the committed changes.
Sybren A. Stüvel (sybren) added a commit: rB948e080fc5bb: Silence `-Wmaybe-uninitialized` warning on GCC/Linux.

Revision Contents
Changeset List

PathSize
build_files/
cmake/
platform/
8 lines

Diff 27969

View Options

build_files/cmake/platform/platform_unix.cmake

Loading...