Page MenuHome
Differential D8632

Fix T79924: Update the view rotation origin after setting the sculpt pivot
ClosedPublic
Actions

Authored by Pablo Dobarro (pablodp606) on Aug 19 2020, 5:52 PM.

Details

Reviewers
Sergey Sharybin (sergey)
Maniphest Tasks
T79924: Sculpt: Can't orbit around a defined / unmasked area when you set the pivot point in sculpt mode
Commits
rBc85144934a7d: Fix T79924: Update the view rotation origin after setting the sculpt pivot
Summary

This updates the view navigation origin after modifying the pivot
position.

Diff Detail

Repository
rB Blender

Event Timeline

Pablo Dobarro (pablodp606) requested review of this revision.Aug 19 2020, 5:52 PM
Pablo Dobarro (pablodp606) created this revision.
Harbormaster completed remote builds in B9648: Diff 27922.Aug 19 2020, 5:52 PM
Pablo Dobarro (pablodp606) added a reviewer: Sergey Sharybin (sergey).Aug 19 2020, 11:20 PM
Sergey Sharybin (sergey) added inline comments.Aug 20 2020, 9:33 AM
source/blender/editors/sculpt_paint/sculpt_transform.c
329

What line of code this comment belongs to?
Don't think tagging has anything to do with the rotation origin, and the notifier should not be used for such things either.

Pablo Dobarro (pablodp606) updated this revision to Diff 27978.Aug 20 2020, 4:02 PM
Pablo Dobarro (pablodp606) marked an inline comment as done.
  • Review update
Harbormaster completed remote builds in B9690: Diff 27978.Aug 20 2020, 4:02 PM
Sergey Sharybin (sergey) accepted this revision.Aug 20 2020, 4:29 PM
This revision is now accepted and ready to land.Aug 20 2020, 4:29 PM
Closed by commit rBc85144934a7d: Fix T79924: Update the view rotation origin after setting the sculpt pivot (authored by Pablo Dobarro (pablodp606)). · Explain WhyAug 20 2020, 5:02 PM
This revision was automatically updated to reflect the committed changes.
Pablo Dobarro (pablodp606) added a commit: rBc85144934a7d: Fix T79924: Update the view rotation origin after setting the sculpt pivot.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
sculpt_paint/
6 lines

Diff 27989

View Options

source/blender/editors/sculpt_paint/sculpt_transform.c

Loading...