Fix T79803: Wrong Distance To Edge 1D Voronoi
ClosedPublic
Actions

Authored by Omar Emara (OmarSquircleArt) on Aug 19 2020, 6:25 PM.

Details

Reviewers

Brecht Van Lommel (brecht)
Jacques Lucke (JacquesLucke)

Maniphest Tasks

T79803: Shading: Voronoi Texture "Distance To Edge" is broken in 1D case

Commits

rC7f5d86c43150: Fix T79803: Wrong Distance To Edge 1D Voronoi
rB340cbc7f1537: Fix T79803: Wrong Distance To Edge 1D Voronoi

Summary

The current 1D Voronoi implementation for the Distance to Edge option
computes the distance to the cells instead. This patch fixes that and
compute the distance to the edge instead.

Diff Detail

Repository

rB Blender

Branch

fix-1d-edge-voronoi (branched from master)

Build Status

Buildable 9650
Build 9650: arc lint + arc unit

Event Timeline

Omar Emara (OmarSquircleArt) requested review of this revision.Aug 19 2020, 6:25 PM

Omar Emara (OmarSquircleArt) created this revision.

Harbormaster completed remote builds in B9650: Diff 27925.Aug 19 2020, 6:25 PM

How does this affect the results? Can you show an example of how it looks before and after this change?

@Jacques Lucke (JacquesLucke) Left is the old result. Right is the new result.

The math makes sense to me. Not sure what @Brecht Van Lommel (brecht) things about the noise pattern change, but given that this only affects 1D voronoi noise, it's probably fine to commit. You should still wait for his approval.

This revision is now accepted and ready to land.Sep 3 2020, 12:42 PM

Brecht Van Lommel (brecht) accepted this revision.Sep 3 2020, 6:38 PM

Closed by commit rB340cbc7f1537: Fix T79803: Wrong Distance To Edge 1D Voronoi (authored by Omar Emara (OmarSquircleArt)). · Explain WhySep 3 2020, 6:55 PM

This revision was automatically updated to reflect the committed changes.

Omar Emara (OmarSquircleArt) added a commit: rB340cbc7f1537: Fix T79803: Wrong Distance To Edge 1D Voronoi.

Robert Guetzkow (rjg) added a task: T79803: Shading: Voronoi Texture "Distance To Edge" is broken in 1D case.Dec 2 2020, 12:09 PM

Stefan Werner (swerner) added a commit: rC7f5d86c43150: Fix T79803: Wrong Distance To Edge 1D Voronoi.Mar 1 2021, 2:18 AM