Page MenuHome
Differential D8635

Geometry: use generic attributes for Hair and Point Clouds
ClosedPublic
Actions

Authored by Brecht Van Lommel (brecht) on Aug 19 2020, 7:20 PM.

Details

Reviewers
Jacques Lucke (JacquesLucke)
Commits
rBa1397a3cc693: Geometry: use generic attributes for Hair and Point Clouds
Summary

Instead of custom data layer with special types, using general Vector and Float
attributes.

Depends on D8200

Diff Detail

Event Timeline

Brecht Van Lommel (brecht) created this revision.Aug 19 2020, 7:20 PM
Harbormaster completed remote builds in B9652: Diff 27929.Aug 19 2020, 7:20 PM
Brecht Van Lommel (brecht) requested review of this revision.Aug 19 2020, 7:20 PM
Brecht Van Lommel (brecht) added a child revision: D8636: Geometry: add Attributes panel for PointCloud and Hair.
Jacques Lucke (JacquesLucke) accepted this revision.Aug 20 2020, 11:37 AM

Why does BKE_id_attribute_rename do error handling with BLI_assert while BKE_id_attribute_remove uses BKE_report. Not saying that has to be changed, just wondering.

This revision is now accepted and ready to land.Aug 20 2020, 11:37 AM
Kenzie (kenziemac130) awarded a token.Aug 22 2020, 11:39 AM
Daniel Bystedt (dbystedt) awarded a token.Aug 24 2020, 10:56 PM
Brecht Van Lommel (brecht) added a comment.Aug 28 2020, 4:42 PM
In D8635#210761, @Jacques Lucke (JacquesLucke) wrote:

Why does BKE_id_attribute_rename do error handling with BLI_assert while BKE_id_attribute_remove uses BKE_report. Not saying that has to be changed, just wondering.

For rename the Python API does not need the reports, so I didn't add them. But I might as well make them consistent, I'll update D8200 for that.

Brecht Van Lommel (brecht) updated this revision to Diff 28281.Aug 28 2020, 5:06 PM

Rebase.

Harbormaster completed remote builds in B9866: Diff 28281.Aug 28 2020, 5:06 PM
Jacques Lucke (JacquesLucke) accepted this revision.Sep 8 2020, 5:28 PM
Closed by commit rBa1397a3cc693: Geometry: use generic attributes for Hair and Point Clouds (authored by Brecht Van Lommel (brecht)). · Explain WhySep 9 2020, 5:01 PM
This revision was automatically updated to reflect the committed changes.
Brecht Van Lommel (brecht) added a commit: rBa1397a3cc693: Geometry: use generic attributes for Hair and Point Clouds.

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
1 line
2 lines
3 lines
intern/
26 lines
21 lines
31 lines
blenloader/
intern/
30 lines
makesdna/
4 lines
makesrna/
intern/
14 lines

Diff 28281

View Options

source/blender/blenkernel/BKE_attribute.h

Loading...
View Options

source/blender/blenkernel/BKE_hair.h

Loading...
View Options

source/blender/blenkernel/BKE_pointcloud.h

Loading...
View Options

source/blender/blenkernel/intern/attribute.c

Loading...
View Options

source/blender/blenkernel/intern/hair.c

Loading...
View Options

source/blender/blenkernel/intern/pointcloud.c

Loading...
View Options

source/blender/blenloader/intern/versioning_290.c

Loading...
View Options

source/blender/makesdna/DNA_customdata_types.h

Loading...
View Options

source/blender/makesrna/intern/rna_attribute.c

Loading...