Geometry: add Attributes panel for PointCloud and Hair
ClosedPublic
Actions

Authored by Brecht Van Lommel (brecht) on Aug 19 2020, 7:21 PM.

Details

Reviewers

Jacques Lucke (JacquesLucke)

Commits

rB370d6e50252b: Geometry: add Attributes panel for PointCloud and Hair

Summary

There is a list of attributes, along with operators to add and remove
attributes. For adding, there are a few standard attributes that can be
added quickly, as well as a popup to create a custom attribute.

Depends on D8635

Diff Detail

Repository

rB Blender

Build Status

Buildable 9653
Build 9653: arc lint + arc unit

Event Timeline

Brecht Van Lommel (brecht) created this revision.Aug 19 2020, 7:21 PM

Harbormaster completed remote builds in B9653: Diff 27930.Aug 19 2020, 7:21 PM

Brecht Van Lommel (brecht) requested review of this revision.Aug 19 2020, 7:21 PM

Brecht Van Lommel (brecht) added a child revision: D8637: Geometry: display generic attributes in the outliner [WIP prototype].Aug 19 2020, 7:26 PM

Philipp Oeser (lichtwerk) added a subscriber: Philipp Oeser (lichtwerk).Aug 19 2020, 7:50 PM

Jacques Lucke (JacquesLucke) accepted this revision.Aug 20 2020, 12:13 PM

Jacques Lucke (JacquesLucke) added inline comments.

release/scripts/startup/bl_ui/properties_data_hair.py
60	I can imagine that this loop will become quite common in scripts. Maybe we should add a `attributes.find(name: str, type: str, domain: str) -> Optional[Attribute]` method.
97	Personal preference: `f"{domain.name} {data_type.name}"`

This revision is now accepted and ready to land.Aug 20 2020, 12:13 PM

Sharath (sharaths21312) awarded a token.Aug 20 2020, 12:28 PM

Sharath (sharaths21312) added a subscriber: Sharath (sharaths21312).

Address comments indirectly.

Tweak layout, to put domain and data type in separate columns.
Gray out based on only the name matching, since multiple data types or domains may be valid.

Harbormaster completed remote builds in B9869: Diff 28284.Aug 28 2020, 6:07 PM

William Reynish (billreynish) awarded a token.Sep 6 2020, 8:21 AM

Jacques Lucke (JacquesLucke) accepted this revision.Sep 8 2020, 5:29 PM

Closed by commit rB370d6e50252b: Geometry: add Attributes panel for PointCloud and Hair (authored by Brecht Van Lommel (brecht)). · Explain WhySep 9 2020, 5:01 PM

This revision was automatically updated to reflect the committed changes.

Brecht Van Lommel (brecht) added a commit: rB370d6e50252b: Geometry: add Attributes panel for PointCloud and Hair.