I see that patch is correct and don't see big issues. You have done a great job.

Also, I noticed the patch includes the changes on Draw Engine for Curves I did. We need test this code with last master changes to be sure the Handles are hidden and displayed depending of the option of the Overlay. I did some changes in master recently and this could be affected.

As general rule, as there are new code (this does not apply to old code):

• Review you use the new datatypes like uint16_t in loops.
• Review comments, must be start with Uppercase and ends with point.
• Add Doxygen text to BKE function (not needed for static function).
• Review some code commented and ToDos. If the ToDos are going to be used in next Phase, just add a comment like To be implemented in Phase II, or something like that.

I would like @Daniel Martinez Lara (pepeland) and @Matias Mendiola (mendio) run a complete test to be sure all is running as expected.

As this patch is tagged to be included in 2.92 we must do a plan of testing and bug fixing to have all ready before end of October.

@Daniel Martinez Lara (pepeland) @Matias Mendiola (mendio) What is the status of the test?

@Falk David (filedescriptor) What is the status of the bugs?

If we think we must have a meeting, we can arrange a meeting. (@Pablo Vazquez (pablovazquez) you are invited, if you want).

So I wanted to take a close look at selection syncing again, because there are some issues there. Also locked layers need to be handled properly. Finally we have this issue of NaN pressure and strength that we need to figure out. I think the last one has the highest priority, since it can cause crashes, so it should be addressed first.