Details

source/blender/blenkernel/BKE_paint.h
207	Style: Use `uchar r_color[4]` to show how many element are needed.
source/blender/draw/intern/draw_cache_extract.h
107	I don't really like the name overlays. Prefer `sculpt_data`. Keep `sculpt_overlay` for the batch.
source/blender/draw/intern/draw_cache_extract_mesh.c
2586	You are falling into a pitfall not guarded by any assert (this is my fault). Using the `vbo->data` (as in `gpuSculptOverlay vbo_data = (gpuSculptOverlay )vbo->data;`) buffer dirrectly is dangerous and needs to be done ONLY if the format has no padding. But yours have. To workaround this, I would suggest to double the size of the VBO (yes i know it's a bit much but this is needed by some hardware) and use this format: `uchar4, float`. The good side is that it make the data filling a bit easier (no conversion needed). See `attr_align(const GPUVertAttr *a)` definition for more information.
2662	Can't this use threading? I don't see any data dependency here.

This revision now requires changes to proceed.Sep 17 2020, 2:52 PM

Rebase
Review Update

Harbormaster completed remote builds in B10281: Diff 29008.Sep 18 2020, 12:16 AM

Clément Foucault (fclem) accepted this revision.Sep 18 2020, 7:02 PM

Clément Foucault (fclem) added inline comments.

source/blender/blenkernel/BKE_paint.h
207	Declaration is not updated.
source/blender/draw/intern/draw_cache_extract_mesh.c
2662	What I meant here, is to make use of the range extract functions. This is not mandatory but if you don't do it, add a TODO comment so someone can pick it up. (and don't set `use_threading = true` if you are not actually doing it)

This revision is now accepted and ready to land.Sep 18 2020, 7:02 PM

Closed by commit rB6c9ec1c893f9: Sculpt: Render Mask and Face Sets with modifiers active (authored by Pablo Dobarro (pablodp606)). · Explain WhySep 18 2020, 7:31 PM

This revision was automatically updated to reflect the committed changes.

Pablo Dobarro (pablodp606) marked 2 inline comments as done.

Pablo Dobarro (pablodp606) added a commit: rB6c9ec1c893f9: Sculpt: Render Mask and Face Sets with modifiers active.

Metin Seven (MetinSeven) awarded a token.Sep 18 2020, 7:58 PM

Sculpt: Render Mask and Face Sets with modifiers active
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 29060

source/blender/blenkernel/BKE_paint.h

source/blender/blenkernel/intern/DerivedMesh.c

source/blender/blenkernel/intern/customdata.c

source/blender/blenkernel/intern/paint.c

source/blender/draw/engines/overlay/overlay_sculpt.c

source/blender/draw/intern/draw_cache_extract.h

source/blender/draw/intern/draw_cache_extract_mesh.c

source/blender/draw/intern/draw_cache_impl.h

source/blender/draw/intern/draw_cache_impl_mesh.c

source/blender/editors/space_view3d/view3d_draw.c

source/blender/gpu/intern/gpu_buffers.c

Sculpt: Render Mask and Face Sets with modifiers activeClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 29060

source/blender/blenkernel/BKE_paint.h

source/blender/blenkernel/intern/DerivedMesh.c

source/blender/blenkernel/intern/customdata.c

source/blender/blenkernel/intern/paint.c

source/blender/draw/engines/overlay/overlay_sculpt.c

source/blender/draw/intern/draw_cache_extract.h

source/blender/draw/intern/draw_cache_extract_mesh.c

source/blender/draw/intern/draw_cache_impl.h

source/blender/draw/intern/draw_cache_impl_mesh.c

source/blender/editors/space_view3d/view3d_draw.c

source/blender/gpu/intern/gpu_buffers.c

Sculpt: Render Mask and Face Sets with modifiers active
ClosedPublic
Actions

Revision Contents
Changeset List