Page MenuHome
Differential D8678

Cleanup interface_handlers.c
ClosedPublic
Actions

Authored by Valentin (Poulpator) on Aug 22 2020, 3:33 PM.

Details

Reviewers
Julian Eisel (Severin)
Hans Goudey (HooglyBoogly)
Commits
rB6e06936c0e41: Cleanup in interface_handlers.c
Summary
  • Reduce variables scope
  • Use some const
  • initialize variables at declaration

Diff Detail

Repository
rB Blender
Branch
copy-cleanup (branched from master)
Build Status
Buildable 9737
Build 9737: arc lint + arc unit

Event Timeline

Valentin (Poulpator) created this revision.Aug 22 2020, 3:33 PM
Harbormaster completed remote builds in B9737: Diff 28059.Aug 22 2020, 3:33 PM
Valentin (Poulpator) requested review of this revision.Aug 22 2020, 3:33 PM
Valentin (Poulpator) edited the summary of this revision. (Show Details)Aug 22 2020, 3:38 PM
Valentin (Poulpator) added reviewers: Julian Eisel (Severin), Hans Goudey (HooglyBoogly).
Hans Goudey (HooglyBoogly) requested changes to this revision.Aug 22 2020, 9:31 PM

Thanks for doing this. One one hand it's pretty surface level stuff, but IMO it's also a good first step in reducing the messiness of this code. Just a few notes:

source/blender/editors/interface/interface_handlers.c
1633–1634

You should be able to use LISTBASE_FOREACH_INDEX here, which I just recently added.

2773–2774

I think it would be best if you move it just a bit further, into the for loop.

4939

You could just remove this

This revision now requires changes to proceed.Aug 22 2020, 9:31 PM
Valentin (Poulpator) updated this revision to Diff 28137.Aug 25 2020, 5:02 PM
  • Adressed comment
  • Also added few checks to false instead of 0 for bool value, sorry I didn't added them in the first pass
Harbormaster completed remote builds in B9781: Diff 28137.Aug 25 2020, 5:02 PM
Hans Goudey (HooglyBoogly) accepted this revision.Aug 25 2020, 7:57 PM
This revision is now accepted and ready to land.Aug 25 2020, 7:57 PM
Closed by commit rB6e06936c0e41: Cleanup in interface_handlers.c (authored by Valentin Fuhrer (valentin), committed by Hans Goudey (HooglyBoogly)). · Explain WhyAug 25 2020, 8:18 PM
This revision was automatically updated to reflect the committed changes.
Hans Goudey (HooglyBoogly) added a commit: rB6e06936c0e41: Cleanup in interface_handlers.c.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
interface/
196 lines

Diff 28059

View Options

source/blender/editors/interface/interface_handlers.c

Loading...