Differential D8680

Fix T80008: Use a better smooth algorithm to smooth mesh boundaries by default
ClosedPublic
Actions

Authored by Pablo Dobarro (pablodp606) on Aug 23 2020, 1:51 AM.

Details

Reviewers

Sergey Sharybin (sergey)

Maniphest Tasks

T80008: Sculpt: 2.9 Unusual behavior of the smooth brush on thin meshes compared to older builds.

Commits

rB5a634735e6e2: Fix T80008: Smooth brush not deforming mesh boundaries correctly

Summary

In 2.83 and previous versions there was a bug that was causing boundary
vertices to be detected incorrectly that was preventing the smooth brush
to work on boundaries if there was a pole on them.
In 2.90 the boundary vertex detection was fixed, but it was still using a
simplified version of the algorithm without any boundary smoothing. This
patch implements a similar smoothing algorithm to what I think it was
the intention of 2.83 and previous versions, but working correctly.

2.83 smooth, this is why the default smooth algorithm was changed:

2.91 after the fix:

Diff Detail

Repository

rB Blender

Branch

T80008 (branched from master)

Build Status

Buildable 9741
Build 9741: arc lint + arc unit

Event Timeline

Pablo Dobarro (pablodp606) created this revision.Aug 23 2020, 1:51 AM

Harbormaster completed remote builds in B9741: Diff 28066.Aug 23 2020, 1:51 AM

Pablo Dobarro (pablodp606) requested review of this revision.Aug 23 2020, 1:51 AM

Pablo Dobarro (pablodp606) edited the summary of this revision. (Show Details)Aug 23 2020, 1:54 AM

Pablo Dobarro (pablodp606) added a reviewer: Sergey Sharybin (sergey).

Chris Kohl (ckohl_art) awarded a token.Aug 23 2020, 9:27 AM

Chris Kohl (ckohl_art) added a subscriber: Chris Kohl (ckohl_art).

Metin Seven (MetinSeven) awarded a token.Aug 23 2020, 9:47 AM

William Reynish (billreynish) awarded a token.Aug 23 2020, 9:50 AM

Emir Sinan Gürlek (filibis) awarded a token.Aug 23 2020, 3:29 PM

Emir Sinan Gürlek (filibis) added a subscriber: Emir Sinan Gürlek (filibis).

Jun Mizutani (jmztn) awarded a token.Aug 23 2020, 5:10 PM

heini (ogonek) awarded a token.Aug 23 2020, 6:11 PM

heini (ogonek) added a subscriber: heini (ogonek).Aug 23 2020, 6:22 PM

Przemyslaw Golab (SirPigeonz) (n-pigeon) awarded a token.Aug 23 2020, 6:59 PM

Przemyslaw Golab (SirPigeonz) (n-pigeon) added a subscriber: Przemyslaw Golab (SirPigeonz) (n-pigeon).

RedMser (RedMser) awarded a token.Aug 24 2020, 3:09 AM

Antti Teittinen (ate1) awarded a token.Aug 24 2020, 8:45 AM

Erick Tukuniata (erickblender) awarded a token.Aug 24 2020, 9:05 AM

Code seems fine, but the commit message needs adjustment. See the guidelines [1]

The title should be clear for users, and release logs. So is better to phrase in a way like "Fix T80008: Smooth brush produces artifacts". Or something like this.

So please adjust the message according to the guidelines and commit to Git.

[1] https://wiki.blender.org/wiki/Style_Guide/Commit_Messages#Bug_Fixes

This revision is now accepted and ready to land.Aug 24 2020, 9:16 AM

Closed by commit rB5a634735e6e2: Fix T80008: Smooth brush not deforming mesh boundaries correctly (authored by Pablo Dobarro (pablodp606)). · Explain WhyAug 24 2020, 11:11 PM

This revision was automatically updated to reflect the committed changes.

Pablo Dobarro (pablodp606) added a commit: rB5a634735e6e2: Fix T80008: Smooth brush not deforming mesh boundaries correctly.

Antti Teittinen (ate1) added a subscriber: Antti Teittinen (ate1).Aug 26 2020, 11:03 AM

Gilberto Rodrigues (gilberto_rodrigues) awarded a token.Aug 28 2020, 4:33 AM