Page MenuHome
Differential D8682

Fix Crash with Continue zoom in the Node Editor (T65714) (Trackpad) [1/5]
ClosedPublic
Actions

Authored by Yevgeny Makarov (jenkm) on Aug 23 2020, 12:39 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
Julian Eisel (Severin)
Maniphest Tasks
T65714: Blender Crashes when using Mac trackpad Pinching(zoom) in Node Editor
Commits
rBc87b7fdd8a50: Fix for T65714: Pinch Zooming Crash using Mac Trackpad
rBcac8a7cddb56: Fix for T65714: Pinch Zooming Crash using Mac Trackpad
Summary

Trackpad: View2D Zoom improvements and fixes (1).

T65714: Blender Crashes when using Mac trackpad Pinching(zoom) in Node Editor

Trackpad never uses the "Continued" zoom method, only "Dolly",
the timer is not initialized, that gives a very large zoom step.

In combination with "Zoom to Mouse Position" which is also buggy,
it will lead to a crash, see comments T65714#992824.

Diff Detail

Repository
rB Blender

Event Timeline

Yevgeny Makarov (jenkm) requested review of this revision.Aug 23 2020, 12:39 PM
Yevgeny Makarov (jenkm) created this revision.
Yevgeny Makarov (jenkm) added a child revision: D8683: Fix Zoom to Mouse Position is broken for View2D (T78211) (Trackpad) [2/5].Aug 23 2020, 12:43 PM
Yevgeny Makarov (jenkm) added a task: T65714: Blender Crashes when using Mac trackpad Pinching(zoom) in Node Editor.Sep 5 2020, 4:13 PM
Yevgeny Makarov (jenkm) retitled this revision from Trackpad: View2D Zoom improvements and fixes (1) to Fix Crash with Continue zoom in the Node Editor (T65714) (Trackpad) [1/5].Oct 6 2020, 6:15 PM
Yevgeny Makarov (jenkm) added a reviewer: Brecht Van Lommel (brecht).
Yevgeny Makarov (jenkm) mentioned this in T82006: Trackpad Support Improvement (Parent Task).Oct 23 2020, 4:18 PM
Julian Eisel (Severin) accepted this revision.Oct 28 2020, 6:15 PM
Julian Eisel (Severin) added a subscriber: Julian Eisel (Severin).

We do similar NULL-checks elsewhere, so this seems to follow the operators logic correctly.

This revision is now accepted and ready to land.Oct 28 2020, 6:15 PM
Yevgeny Makarov (jenkm) updated this revision to Diff 30475.Oct 28 2020, 7:36 PM

rebase

Yevgeny Makarov (jenkm) updated this revision to Diff 30478.Oct 28 2020, 8:09 PM

better comment

Closed by commit rBcac8a7cddb56: Fix for T65714: Pinch Zooming Crash using Mac Trackpad (authored by Yevgeny Makarov (jenkm), committed by Harley Acheson (harley)). · Explain WhyOct 29 2020, 12:41 AM
This revision was automatically updated to reflect the committed changes.
Harley Acheson (harley) added a commit: rBcac8a7cddb56: Fix for T65714: Pinch Zooming Crash using Mac Trackpad.
Harley Acheson (harley) added a commit: rBc87b7fdd8a50: Fix for T65714: Pinch Zooming Crash using Mac Trackpad.Nov 7 2020, 2:52 AM

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
interface/
5 lines

Diff 30484

View Options

source/blender/editors/interface/view2d_ops.c

Loading...