Page MenuHome
Differential D8683

Fix Zoom to Mouse Position is broken for View2D (T78211) (Trackpad) [2/5]
ClosedPublic
Actions

Authored by Yevgeny Makarov (jenkm) on Aug 23 2020, 12:40 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
Maniphest Tasks
T78211: Zoom to Mouse Position is broken in Node Editor (with Trackpad, macOS)
Commits
rBd7b0ec9cb5f3: Fix for T78211: Trackpad Zoom to Mouse Position Error
rBc1b30e0ed176: Fix for T78211: Trackpad Zoom to Mouse Position Error
Summary

Trackpad: View2D Zoom improvements and fixes (2).

T78211: Zoom to Mouse Position is broken in Node Editor (with Trackpad, macOS)
T70749: Zooming with MacBook Pro trackpad zooms to random location

Zoom to Mouse Position always zooms to the center of the canvas,
need store initial mouse position before applying trackpad zoom.

Diff Detail

Repository
rB Blender

Event Timeline

Yevgeny Makarov (jenkm) requested review of this revision.Aug 23 2020, 12:40 PM
Yevgeny Makarov (jenkm) created this revision.
Yevgeny Makarov (jenkm) added a child revision: D8684: Fix T43554: Zoom to Mouse Position makes 2D Views pan after zoom limits are reached.Aug 23 2020, 12:43 PM
Yevgeny Makarov (jenkm) added a parent revision: D8682: Fix Crash with Continue zoom in the Node Editor (T65714) (Trackpad) [1/5].
Yevgeny Makarov (jenkm) added a task: T78211: Zoom to Mouse Position is broken in Node Editor (with Trackpad, macOS).Sep 5 2020, 4:15 PM
Yevgeny Makarov (jenkm) retitled this revision from Trackpad: View2D Zoom improvements and fixes (2) to Fix Zoom to Mouse Position is broken for View2D (T78211) (Trackpad) [2/5].Oct 6 2020, 6:14 PM
Yevgeny Makarov (jenkm) added a reviewer: Brecht Van Lommel (brecht).
Brecht Van Lommel (brecht) accepted this revision.Oct 12 2020, 3:04 PM
This revision is now accepted and ready to land.Oct 12 2020, 3:04 PM
Yevgeny Makarov (jenkm) mentioned this in T82006: Trackpad Support Improvement (Parent Task).Oct 23 2020, 4:18 PM
Yevgeny Makarov (jenkm) updated this revision to Diff 30500.Oct 29 2020, 4:07 PM
Closed by commit rBc1b30e0ed176: Fix for T78211: Trackpad Zoom to Mouse Position Error (authored by Yevgeny Makarov (jenkm), committed by Harley Acheson (harley)). · Explain WhyOct 29 2020, 4:41 PM
This revision was automatically updated to reflect the committed changes.
Harley Acheson (harley) added a commit: rBc1b30e0ed176: Fix for T78211: Trackpad Zoom to Mouse Position Error.
Harley Acheson (harley) added a commit: rBd7b0ec9cb5f3: Fix for T78211: Trackpad Zoom to Mouse Position Error.Nov 7 2020, 2:58 AM

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
interface/
13 lines

Diff 30503

View Options

source/blender/editors/interface/view2d_ops.c

Loading...