Fix T79819: crash with OSL trace() and getmessage() after Embree changes
ClosedPublic
Actions

Authored by Brecht Van Lommel (brecht) on Aug 24 2020, 3:13 PM.

Details

Reviewers

Sergey Sharybin (sergey)
Stefan Werner (swerner)

Maniphest Tasks

T79819: Crash with OSL shader when checking results from getmessage trace "geom:name"

Commits

rCfe229bc91ac3: Fix T79819: crash with OSL trace() and getmessage() after Embree changes
rBdc74d60915e5: Fix T79819: crash with OSL trace() and getmessage() after Embree changes

Summary

The return value of scene_intersect must be checked, the isect struct members
can't be assumed to be initialized if that returns false.

Diff Detail

Repository: rB Blender

Event Timeline

Brecht Van Lommel (brecht) requested review of this revision.Aug 24 2020, 3:13 PM

Brecht Van Lommel (brecht) created this revision.

Harbormaster completed remote builds in B9752: Diff 28091.Aug 24 2020, 3:14 PM

Brecht Van Lommel (brecht) added a task: T79819: Crash with OSL shader when checking results from getmessage trace "geom:name".Aug 24 2020, 3:14 PM

Sergey Sharybin (sergey) accepted this revision.Aug 24 2020, 4:12 PM

This revision is now accepted and ready to land.Aug 24 2020, 4:12 PM

Closed by commit rBdc74d60915e5: Fix T79819: crash with OSL trace() and getmessage() after Embree changes (authored by Brecht Van Lommel (brecht)). · Explain WhyAug 24 2020, 6:06 PM

This revision was automatically updated to reflect the committed changes.

Brecht Van Lommel (brecht) added a commit: rBdc74d60915e5: Fix T79819: crash with OSL trace() and getmessage() after Embree changes.

Brecht Van Lommel (brecht) added a commit: rCfe229bc91ac3: Fix T79819: crash with OSL trace() and getmessage() after Embree changes.Sep 1 2020, 1:58 AM

Revision Contents
Changeset List

Path

Size

intern/

cycles/

kernel/

osl/

osl_globals.h

1 line

osl_services.cpp

8 lines

Diff 28106

View Options

intern/cycles/kernel/osl/osl_globals.h