Enabled workaround to solve threading issues in draw manager
ClosedPublic
Actions

Authored by Jeroen Bakker (jbakker) on Aug 24 2020, 4:26 PM.

Details

Reviewers

Clément Foucault (fclem)
Dalai Felinto (dfelinto)

Maniphest Tasks

T79038: Blender freezes on vertex paint on linked mesh data.
T79533: Crash when opening file

Commits

rB263cf2ea945a: Enabled workaround to solve threading issues in draw manager
rB141a8ff6b3b1: Enabled workaround to solve threading issues in draw manager

Summary

This workaround addresses T79533 and T79038 for Blender 2.90. The
solution isn't clear and needs more research and work. In order to
continue with blender 2.90 release it was proposed to add this work
around.

It has been tested with the test files provided in the reports.

Diff Detail

Repository: rB Blender

Event Timeline

Jeroen Bakker (jbakker) requested review of this revision.Aug 24 2020, 4:26 PM

Jeroen Bakker (jbakker) created this revision.

Harbormaster completed remote builds in B9757: Diff 28098.Aug 24 2020, 4:27 PM

Jeroen Bakker (jbakker) retitled this revision from Enabled workaround for draw manager threading issues to Enabled workaround to solve threading issues in draw manager.Aug 24 2020, 4:29 PM

Jeroen Bakker (jbakker) added projects: BF Blender (2.90), EEVEE & Viewport.

I'm still building here to test, but I would recommend merging T79533 into T79038 so you only need to mention one here.

Jeroen Bakker (jbakker) added tasks: T79533: Crash when opening file, T79038: Blender freezes on vertex paint on linked mesh data. .Aug 24 2020, 4:33 PM

Are we 100% certain that the issues are the same. One seems to be windows + nvidia other one is on all platforms. One is vertex painting, other is loading a file. I would keep them separate for now, until we know for certain that the detailed cause is the same. otherwise we need to separate them in different patches...

I can confirm it fixes T79533.

Nothing alarming with the patch with my tests. But even without the patch I'm failing to vertex paint in complex geometry (e.g., cape_GEO from the wanderer.blend sample file)

Clément Foucault (fclem) accepted this revision.Aug 24 2020, 4:57 PM

This revision is now accepted and ready to land.Aug 24 2020, 4:57 PM

Dalai Felinto (dfelinto) accepted this revision.Aug 24 2020, 4:57 PM

Closed by commit rB141a8ff6b3b1: Enabled workaround to solve threading issues in draw manager (authored by Jeroen Bakker (jbakker)). · Explain WhyAug 25 2020, 8:19 AM

This revision was automatically updated to reflect the committed changes.

Jeroen Bakker (jbakker) added a commit: rB141a8ff6b3b1: Enabled workaround to solve threading issues in draw manager.

Jeroen Bakker (jbakker) added a reverting change: rB024a9d17d29d: Revert "Enabled workaround to solve threading issues in draw manager".Aug 25 2020, 11:29 AM

Jeroen Bakker (jbakker) added a commit: rB263cf2ea945a: Enabled workaround to solve threading issues in draw manager.Aug 25 2020, 11:50 AM