This skips the subdivision operation if the mesh has no faces, avoiding
the crash.
Details
Details
- Reviewers
Sergey Sharybin (sergey) - Maniphest Tasks
- T80039: Blender crashes when in the Multresolution modifier we increase the number of subdivisions
- Commits
- rBdc61f7c17178: Fix T80039: Do not subdivide with Multires is mesh has no faces
rB1bced5884c3d: Fix T80039: Do not subdivide with Multires is mesh has no faces
Diff Detail
Diff Detail
- Repository
- rB Blender
- Branch
- T80039 (branched from master)
- Build Status
Buildable 9762 Build 9762: arc lint + arc unit
Event Timeline
Comment Actions
Generally fine. Some minor suggestions.
Accepting, so that you can commit this early on to 2.90 branch (as I understood 2.90 crashes). Use common sense when addressing the suggestions :)
| source/blender/blenkernel/intern/multires_reshape.c | ||
|---|---|---|
| 194–196 | Move right after if (top_level <= mmd->totlvl) {, so that all early outputs are at the top. Might also state the obvious that "If there are no loops in the mesh inplies there is no CD_MDISPS as well. So can early output from here as there is nothing to subdivide." | |