Fix T77900: File Browser in macOS fullscreen crashes
ClosedPublic
Actions

Authored by Yevgeny Makarov (jenkm) on Aug 26 2020, 1:27 AM.

Details

Reviewers

Maniphest Tasks

T77900: Closing secondary full screen window destroys main Blender window too Part 2

Commits

rBc4b9e2da8c3c: Fix T77900: File Browser in macOS fullscreen crashes
rB0330d1af29c0: Fix T77900: File Browser in macOS fullscreen crashes
rB2ef5fabec9ac: Fix T77900: File Browser in macOS fullscreen crashes

Summary

When Blender is started in fullscreen mode from the command line,
or if the fullscreen state is saved in the startup file, all temporary windows
will also open in fullscreen mode. When closing the fullscreen File Browser,
Blender would either crash or parent window becomes black.

This does not happen if the Blender switches to full screen manually.

NSWindowCollectionBehaviorFullScreenPrimary
should be set for windows that assume full-screen mode.

Diff Detail

Repository: rB Blender

Event Timeline

Yevgeny Makarov (jenkm) requested review of this revision.Aug 26 2020, 1:27 AM

Yevgeny Makarov (jenkm) created this revision.

Yevgeny Makarov (jenkm) added a task: T77900: Closing secondary full screen window destroys main Blender window too Part 2.Aug 26 2020, 10:12 AM

For the record, before 2.83, I guess it's rB57801426792c rBbf361fc9a00c,
if you save the startup file, when Blender is running in fullscreen mode,
this state is not saved in startup file. So, the Blender never started automatically
in full screen and the problem didn't show up.

Julian Eisel (Severin) accepted this revision.Aug 26 2020, 4:30 PM

This revision is now accepted and ready to land.Aug 26 2020, 4:30 PM

Closed by commit rB2ef5fabec9ac: Fix T77900: File Browser in macOS fullscreen crashes (authored by Yevgeny Makarov (jenkm), committed by Julian Eisel (Severin)). · Explain WhyAug 26 2020, 4:31 PM

This revision was automatically updated to reflect the committed changes.

Julian Eisel (Severin) added a commit: rB2ef5fabec9ac: Fix T77900: File Browser in macOS fullscreen crashes.

Julian Eisel (Severin) mentioned this in D8736: Fix T77900: File Browser in macOS fullscreen crashes.Aug 27 2020, 5:10 PM

Julian Eisel (Severin) added a commit: rB0330d1af29c0: Fix T77900: File Browser in macOS fullscreen crashes.Aug 31 2020, 1:29 PM

Jeroen Bakker (jbakker) added a commit: rBc4b9e2da8c3c: Fix T77900: File Browser in macOS fullscreen crashes.Sep 2 2020, 3:07 PM