Paths

Table of Contentst

Fix T80098: Mesh deform doesn't update in edit mode
ClosedPublic
Actions

Authored by Campbell Barton (campbellbarton) on Aug 26 2020, 4:36 AM.

Details

Reviewers

Sebastian Parborg (zeddb)
Brecht Van Lommel (brecht)

Maniphest Tasks

T80098: Mesh deform doesn't update in edit mode.

Summary

Use BKE_mesh_wrapper API access to access mesh coordinates for modifier evaluation.

Call BKE_mesh_wrapper_ensure_mdata when binding since it's a one off operation.

Regression from deaff945d0b965d1e588cdecd084080b07db2e1f

Tested with both the cage and the modified meshes are edit-meshes.

Diff Detail

Repository

rB Blender

Branch

TEMP-T80098-FIX (branched from master)

Build Status

Buildable 9793
Build 9793: arc lint + arc unit

Event Timeline

Campbell Barton (campbellbarton) requested review of this revision.Aug 26 2020, 4:36 AM

Campbell Barton (campbellbarton) created this revision.

Harbormaster completed remote builds in B9793: Diff 28158.Aug 26 2020, 4:36 AM

Campbell Barton (campbellbarton) edited the summary of this revision. (Show Details)Aug 26 2020, 4:41 AM

Campbell Barton (campbellbarton) added a reviewer: Sebastian Parborg (zeddb).

Campbell Barton (campbellbarton) added a project: BF Blender (2.90).

Campbell Barton (campbellbarton) edited the summary of this revision. (Show Details)

Campbell Barton (campbellbarton) edited the summary of this revision. (Show Details)Aug 26 2020, 4:48 AM

Campbell Barton (campbellbarton) added a task: T80098: Mesh deform doesn't update in edit mode..

Brecht Van Lommel (brecht) accepted this revision.Aug 26 2020, 1:03 PM

This revision is now accepted and ready to land.Aug 26 2020, 1:03 PM

Ok seems like my files is a bit corrupted. (?)

If I create a new file in 2.83 and load it up with this patch it works.

But if I open up the file attached in this ticket I have to rebind it before it works in both 2.83 and newer versions.

Other than removing the unused variable, this looks good to me.

source/blender/modifiers/intern/MOD_meshdeform.c
358	`cagecos` is now unused, remove it.

Campbell Barton (campbellbarton) mentioned this in rBe0772c6607ae: Fix T80098: Mesh deform doesn't update in edit mode.Aug 26 2020, 3:24 PM

Committed rBe0772c6607ae6cd48193101b39d7332cb76ab2c9

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

armature/

meshlaplacian.c

4 lines

modifiers/

intern/

MOD_meshdeform.c

26 lines

Diff 28158

View Options

source/blender/editors/armature/meshlaplacian.c