Sculpt: Sculpt Face Set gestures tools
ClosedPublic
Actions

Authored by Pablo Dobarro (pablodp606) on Aug 26 2020, 4:20 PM.

Details

Reviewers

Commits

rBc05715b03fe7: Sculpt: Sculpt Face Set gestures tools

Summary

This implements the sculpt gesture lasso and box operators for face
sets. They work the same way as the mask gesture operator and tools.

Diff Detail

Repository

rB Blender

Branch

arcpatch-D8716 (branched from master)

Build Status

Buildable 9960
Build 9960: arc lint + arc unit

Event Timeline

Pablo Dobarro (pablodp606) created this revision.Aug 26 2020, 4:20 PM

Harbormaster completed remote builds in B9809: Diff 28186.Aug 26 2020, 4:20 PM

Pablo Dobarro (pablodp606) requested review of this revision.Aug 26 2020, 4:20 PM

Pablo Dobarro (pablodp606) retitled this revision from Sculpt: Sculpt Face Set gestures tool to Sculpt: Sculpt Face Set gestures tools.Aug 26 2020, 4:21 PM

Pablo Dobarro (pablodp606) edited the summary of this revision. (Show Details)

Pablo Dobarro (pablodp606) added a reviewer: Sergey Sharybin (sergey).

Brandon (Brandon777) awarded a token.Aug 26 2020, 10:34 PM

Kenn Nyström (Frozen_Death_Knight) awarded a token.Aug 26 2020, 10:43 PM

Przemyslaw Golab (SirPigeonz) (n-pigeon) awarded a token.Aug 27 2020, 3:56 PM

Przemyslaw Golab (SirPigeonz) (n-pigeon) added a subscriber: Przemyslaw Golab (SirPigeonz) (n-pigeon).

Pablo Dobarro (pablodp606) mentioned this in T80390: Sculpt Mode Gesture Tools.Sep 2 2020, 6:34 PM

Similar to the comment from D8599#214204: the technical implementation of code should be brought up to 2020 standards.

Sure the code in this patch was done before that comment, so probably better to move forward with this implementation but plan to do proper refactor in the near future. For example, tomorrow ;)

P.S. The inlined comment should be addressed before commit.