As part of this right-click select post, this adds an alternating row theme color to the file browser (similar to the outliner).
Add-on themes are updated in D8721
Details
Details
- Reviewers
Julian Eisel (Severin) Hans Goudey (HooglyBoogly) - Group Reviewers
User Interface - Commits
- rB479ce00809af: UI: Use alternating row theme color in file browser
Diff Detail
Diff Detail
- Repository
- rB Blender
Event Timeline
Comment Actions
Looks good. @RedMser (RedMser) can you provide the updated themes? I'd rather commit these things all together so nothing is forgotten.
Comment Actions
Since custom themes are part of the addons repository, I'm wondering, does arc diff work as expected for submodules as well (adding the theme changes to this revision)? Or what's the best way of uploading them (a second differential on the addons repo, etc.)?
Comment Actions
IIRC arc does work there, but you will have to create a separate differential for it. But you can also just create a manual diff (e.g. with git diff > /some/path/name.diff in the add-on directory) and attach that here.
Comment Actions
- Update blender light theme to fit changes done to add-on themes
- Changes to add-on themes: D8721
To create these, I copied the outliner's alternating row color + background color, then ensured that the text is still readable
Comment Actions
Good improvement here in my opinion, especially since the outliner already works this way.
I believe that the colors should be set consistently with the outliner though? If I copy the outliner colors to the file browser it looks fine to me.
Other than that, good to go I think. If you had a diff ready for the bundled themes I could commit that at the same time.
EDIT: I commented here before I saw Julian's review. Oops!
Comment Actions
Synchronizing the Outliner and File Browser options makes sense to me. The difference is barely noticeable anyway.