Page MenuHome

UI: Expose important settings from file browser popovers
ClosedPublic

Authored by Hans Goudey (HooglyBoogly) on Aug 26 2020, 5:47 PM.
Tokens
"Love" token, awarded by Xlindvain."Love" token, awarded by rawalanche."Love" token, awarded by gilberto_rodrigues."Love" token, awarded by pablovazquez."Like" token, awarded by erickblender."Burninate" token, awarded by Geronimooo."Love" token, awarded by harley."Love" token, awarded by jfmatheu."Like" token, awarded by EAW."Like" token, awarded by RedMser.

Details

Summary

We have established a convention recently of exposing the most important
settings from popovers, then aligning a popover to control more detailed
settings.

The file browser has some nice display / filtering settings, but they're
hidden in popovers at the moment, so it's sometimes a pain to use them.
The "display as" options now echoes the viewport shading popover, and
filter settings echoes the overlays popover. This convention is familiar
and intuitive for users and makes interaction faster.

BeforeAfter

It works well with small widths because of the flow layout that's already used in this area.

Diff Detail

Repository
rB Blender

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Aug 26 2020, 5:47 PM
Hans Goudey (HooglyBoogly) created this revision.

This is amazing!

I suggest a few more changes:

Awesome! 👍

I like the notes by @Yevgeny Makarov (jenkm), could you please address those changes as well? Thanks!!

This revision is now accepted and ready to land.Sep 2 2020, 5:04 PM

I was a bit hesitant to include that in this patch because I thought removing the icons might be
more controversial. Personally I like the idea of having icons here, but I don't think these are
the best icons of the set-- the line weights are a bit thin IMO. So I'm fine removing them here.

@Hans Goudey (HooglyBoogly) - I thought removing the icons might be more controversial.

I prefer that list without the icons. Looks great.

Julian Eisel (Severin) accepted this revision.EditedSep 3 2020, 11:28 AM

This does seem like a nice improvement to me. I'm fine with moving the items (rather than having them be a shortcut with the extended version in the popup), like here in the patch.
One thing that is slightly odd is that the filter popup shows the "Show Hidden" item, which also has an effect if filtering is disabled. Still seems acceptable though.

I would suggest increasing the window size a little bit (see userdef_default.c). Horizontally more than vertically. Other than that, looks good to me. Also tested on hiDPI.