Page MenuHome
Differential D872

Blender metadata changes to accommodate non string data
ClosedPublic
Actions

Authored by Campbell Barton (campbellbarton) on Nov 2 2014, 9:40 PM.

Details

Reviewers
Sergey Sharybin (sergey)
Martijn Berger (juicyfruit)
Commits
rBS5ac7e23e8863: Blender metadata changes to accommodate non string data
rB5ac7e23e8863: Blender metadata changes to accommodate non string data
Summary

Work towards T42418

Not finished. @campbell please do not spend large amounts of time to review as I need to clean make consistent etc etc

For now got rid of linked list holding key,value pairs for metadata in favour of ID properties.

Next:

  • Store int and float properly and convert to string if format does not support it.
  • Add way so render api client can set attributes, RNA ??
  • Export cycles transformationMatrix

Diff Detail

Repository
rB Blender

Event Timeline

Martijn Berger (juicyfruit) updated this revision to Diff 2819.Nov 2 2014, 9:40 PM
Martijn Berger (juicyfruit) retitled this revision from to Blender metadata changes to accommodate non string data.
Martijn Berger (juicyfruit) updated this object.
Martijn Berger (juicyfruit) added a reviewer: Campbell Barton (campbellbarton).
Martijn Berger (juicyfruit) added a project: BF Blender.
Campbell Barton (campbellbarton) commandeered this revision.Nov 3 2014, 4:57 PM
Campbell Barton (campbellbarton) edited reviewers, added: Martijn Berger (juicyfruit); removed: Campbell Barton (campbellbarton).
Campbell Barton (campbellbarton) updated this revision to Diff 2825.Nov 3 2014, 4:57 PM
Campbell Barton (campbellbarton) updated this object.

modify ID-Prop API use

Sergey Sharybin (sergey) added a subscriber: Sergey Sharybin (sergey).Jan 28 2015, 6:54 PM
Sergey Sharybin (sergey) added inline comments.
source/blender/imbuf/intern/metadata.c
75

Spaces around braces are wrong.

source/blender/imbuf/intern/png.c
406

Same as above.

414

And again.

Sergey Sharybin (sergey) accepted this revision.Jan 28 2015, 6:55 PM
Sergey Sharybin (sergey) added a reviewer: Sergey Sharybin (sergey).

Once those minor things are solved think it's nice patch to have.

This revision is now accepted and ready to land.Jan 28 2015, 6:55 PM
Closed by commit rB5ac7e23e8863: Blender metadata changes to accommodate non string data (authored by Martijn Berger (juicyfruit)). · Explain WhyJan 31 2015, 5:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
source/
blender/
imbuf/
4 lines
intern/
7 lines
41 lines
105 lines
openexr/
13 lines
28 lines

Diff 3317

View Options

source/blender/imbuf/IMB_imbuf_types.h

Loading...
View Options

source/blender/imbuf/intern/IMB_metadata.h

Loading...
View Options

source/blender/imbuf/intern/jpeg.c

Loading...
View Options

source/blender/imbuf/intern/metadata.c

Loading...
View Options

source/blender/imbuf/intern/openexr/openexr_api.cpp

Loading...
View Options

source/blender/imbuf/intern/png.c

Loading...